Remove partially implemented PDF FFI_* handlers

Remove partially implemented PDF FFI_* handlers

Returning NULL will allow pdfium to continue, with some
missing content, rather than crashing outright.

BUG=pdfium:382
BUG=pdfium:383
Committed: https://crrev.com/0d73762fb81356b5bf1832f4bc083b4946d182f8
Cr-Commit-Position: refs/heads/master@{#376210}

[Tom Sepez, 2016-02-18 00:20:33]

Description was changed from

==========
Remove partially implemented PDF FFI_* handlers

Returning NULL will allow pdfium to continue, with some
missing content, rather than crashing outright.

BUG=pdfium:382
BUG=pdfium:383
==========

to

==========
Remove partially implemented PDF FFI_* handlers

Returning NULL will allow pdfium to continue, with some
missing content, rather than crashing outright.

BUG=pdfium:382
BUG=pdfium:383
==========

[Tom Sepez, 2016-02-18 00:20:33]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-02-18 00:21:19]

Lei, please review.  I'm willing to trade a crash for missing functionality ...

[Lei Zhang, 2016-02-18 01:13:11]

lgtm

https://codereview.chromium.org/1709833002/diff/1/pdf/pdfium/pdfium_engine.cc
File pdf/pdfium/pdfium_engine.cc (right):

https://codereview.chromium.org/1709833002/diff/1/pdf/pdfium/pdfium_engine.cc...
pdf/pdfium/pdfium_engine.cc:656: #define XFA_TESTFILE(filename) "E:/"#filename
Remove?

https://codereview.chromium.org/1709833002/diff/1/pdf/pdfium/pdfium_engine.cc...
pdf/pdfium/pdfium_engine.cc:715: FPDF_RESULT Sample_Flush(FPDF_LPVOID
client_data) {
Are we going to get warnings / errors about Sample_Flush() and friends being
unused?

[Tom Sepez, 2016-02-18 17:52:44]

https://codereview.chromium.org/1709833002/diff/1/pdf/pdfium/pdfium_engine.cc
File pdf/pdfium/pdfium_engine.cc (right):

https://codereview.chromium.org/1709833002/diff/1/pdf/pdfium/pdfium_engine.cc...
pdf/pdfium/pdfium_engine.cc:656: #define XFA_TESTFILE(filename) "E:/"#filename
On 2016/02/18 01:13:11, Lei Zhang wrote:
> Remove?

Done.

https://codereview.chromium.org/1709833002/diff/1/pdf/pdfium/pdfium_engine.cc...
pdf/pdfium/pdfium_engine.cc:715: FPDF_RESULT Sample_Flush(FPDF_LPVOID
client_data) {
On 2016/02/18 01:13:11, Lei Zhang wrote:
> Are we going to get warnings / errors about Sample_Flush() and friends being
> unused?
Not anymore - I removed all this.

[Tom Sepez, 2016-02-18 17:52:49]

The CQ bit was checked by tsepez@chromium.org

[Tom Sepez, 2016-02-18 17:52:49]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/1709833002/#ps20001
(title: "Remove unused code.")

[commit-bot: I haz the power, 2016-02-18 17:56:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1709833002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1709833002/20001

[commit-bot: I haz the power, 2016-02-18 18:45:59]

Description was changed from

==========
Remove partially implemented PDF FFI_* handlers

Returning NULL will allow pdfium to continue, with some
missing content, rather than crashing outright.

BUG=pdfium:382
BUG=pdfium:383
==========

to

==========
Remove partially implemented PDF FFI_* handlers

Returning NULL will allow pdfium to continue, with some
missing content, rather than crashing outright.

BUG=pdfium:382
BUG=pdfium:383
==========

[commit-bot: I haz the power, 2016-02-18 18:46:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-18 18:46:49]

Description was changed from

==========
Remove partially implemented PDF FFI_* handlers

Returning NULL will allow pdfium to continue, with some
missing content, rather than crashing outright.

BUG=pdfium:382
BUG=pdfium:383
==========

to

==========
Remove partially implemented PDF FFI_* handlers

Returning NULL will allow pdfium to continue, with some
missing content, rather than crashing outright.

BUG=pdfium:382
BUG=pdfium:383

Committed: https://crrev.com/0d73762fb81356b5bf1832f4bc083b4946d182f8
Cr-Commit-Position: refs/heads/master@{#376210}
==========

[commit-bot: I haz the power, 2016-02-18 18:46:50]

Patchset 2 (id:??) landed as
https://crrev.com/0d73762fb81356b5bf1832f4bc083b4946d182f8
Cr-Commit-Position: refs/heads/master@{#376210}