Remove partially implemented PDF FFI_* handlers

pdf/pdfium/pdfium_engine.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "pdf/pdfium/pdfium_engine.h"
 
 #include <math.h>
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 635 matching lines @@
   }
   FPDFAvail_Destroy(fpdf_availability_);
 
   STLDeleteElements(&pages_);
 }
 
 #ifdef PDF_USE_XFA
 
 //  This is just for testing, needs to be removed later
 #if defined(WIN32)
 #define XFA_TESTFILE(filename) "E:/"#filename

[Lei Zhang, 2016/02/18 01:13:11]

Remove?

[Tom Sepez, 2016/02/18 17:52:44]

Done.

 #else
 #define XFA_TESTFILE(filename) "/home/"#filename
 #endif
 
 struct FPDF_FILE {
   FPDF_FILEHANDLER file_handler;
   FILE* file;
 };
 
 void Sample_Release(FPDF_LPVOID client_data) {
@@ skipping 38 matching lines @@
   if (!client_data)
     return -1;
   FPDF_FILE* file_wrapper = (FPDF_FILE*)client_data;
   if (fseek(file_wrapper->file, (long)offset, SEEK_SET))
     return -1;
   // Write data
   size_t write_size = fwrite(buffer, 1, size, file_wrapper->file);
   return write_size == size ? 0 : -1;
 }
 
 FPDF_RESULT Sample_Flush(FPDF_LPVOID client_data) {

[Lei Zhang, 2016/02/18 01:13:11]

Are we going to get warnings / errors about Sample_Flush() and friends being
unused?

[Tom Sepez, 2016/02/18 17:52:44]

Not anymore - I removed all this.

   if (!client_data)
     return -1;
   // Flush file
   fflush(((FPDF_FILE*)client_data)->file);
   return 0;
 }
 
 FPDF_RESULT Sample_Truncate(FPDF_LPVOID client_data, FPDF_DWORD size) {
   return 0;
 }
@@ skipping 143 matching lines @@
                                  FPDF_FILEHANDLER* file_handle,
                                  int file_flag,
                                  FPDF_WIDESTRING to) {
   std::string to_str =
       base::UTF16ToUTF8(reinterpret_cast<const base::char16*>(to));
   // TODO: needs the full implementation of form uploading
 }
 
 FPDF_LPFILEHANDLER PDFiumEngine::Form_DownloadFromURL(FPDF_FORMFILLINFO* param,
                                                       FPDF_WIDESTRING url) {
-  std::string url_str =
-      base::UTF16ToUTF8(reinterpret_cast<const base::char16*>(url));
-
-  // Now should get data from url.
-  // For testing purpose, use data read from file
-  // TODO: needs the full implementation here
-  FILE* file = fopen(XFA_TESTFILE("downloadtest.tem"), "w");
-
-  FPDF_FILE* file_wrapper = new FPDF_FILE;
-  file_wrapper->file = file;
-  file_wrapper->file_handler.clientData = file_wrapper;
-  file_wrapper->file_handler.Flush = Sample_Flush;
-  file_wrapper->file_handler.GetSize = Sample_GetSize;
-  file_wrapper->file_handler.ReadBlock = Sample_ReadBlock;
-  file_wrapper->file_handler.Release = Sample_Release;
-  file_wrapper->file_handler.Truncate = Sample_Truncate;
-  file_wrapper->file_handler.WriteBlock = Sample_WriteBlock;
-
-  return &file_wrapper->file_handler;
+  // NOTE: Think hard about the security implications before allowing
+  // a PDF file to perform this action.
+  return nullptr;
 }
 
 FPDF_FILEHANDLER* PDFiumEngine::Form_OpenFile(FPDF_FORMFILLINFO* param,
                                               int file_flag,
                                               FPDF_WIDESTRING url,
                                               const char* mode) {
-  std::string url_str = url ?
-      base::UTF16ToUTF8(reinterpret_cast<const base::char16*>(url)) : "NULL";
-
-  // TODO: need to implement open file from the url
-  // Use a file path for the ease of testing
-  FILE* file = fopen(XFA_TESTFILE("tem.txt"), mode);
-  FPDF_FILE* file_wrapper = new FPDF_FILE;
-  file_wrapper->file = file;
-  file_wrapper->file_handler.clientData = file_wrapper;
-  file_wrapper->file_handler.Flush = Sample_Flush;
-  file_wrapper->file_handler.GetSize = Sample_GetSize;
-  file_wrapper->file_handler.ReadBlock = Sample_ReadBlock;
-  file_wrapper->file_handler.Release = Sample_Release;
-  file_wrapper->file_handler.Truncate = Sample_Truncate;
-  file_wrapper->file_handler.WriteBlock = Sample_WriteBlock;
-  return &file_wrapper->file_handler;
+  // NOTE: Think hard about the security implications before allowing
+  // a PDF file to perform this action.
+  return nullptr;
 }
 
 void PDFiumEngine::Form_GotoURL(FPDF_FORMFILLINFO* param,
                                 FPDF_DOCUMENT document,
                                 FPDF_WIDESTRING url) {
   std::string url_str =
       base::UTF16ToUTF8(reinterpret_cast<const base::char16*>(url));
   // TODO: needs to implement GOTO URL action
 }
 
@@ skipping 3041 matching lines @@
     double* height) {
   FPDF_DOCUMENT doc = FPDF_LoadMemDocument(pdf_buffer, pdf_buffer_size, NULL);
   if (!doc)
     return false;
   bool success = FPDF_GetPageSizeByIndex(doc, page_number, width, height) != 0;
   FPDF_CloseDocument(doc);
   return success;
 }
 
 }  // namespace chrome_pdf