Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1449)

Unified Diff: test/backend/metadata_test.dart

Issue 1709633003: Add the ability to add tags in the test config. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/runner/configuration/load.dart ('k') | test/runner/configuration/tags_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/backend/metadata_test.dart
diff --git a/test/backend/metadata_test.dart b/test/backend/metadata_test.dart
index adc8e78969801d272971596071c8692b60eba771..6fc200a60746bbe78df304e1e11d66c6899c8799 100644
--- a/test/backend/metadata_test.dart
+++ b/test/backend/metadata_test.dart
@@ -68,7 +68,7 @@ void main() {
expect(metadata.verboseTrace, isTrue);
expect(metadata.skip, isFalse);
- expect(metadata.tags, ['bar', 'baz']);
+ expect(metadata.tags, unorderedEquals(['bar', 'baz']));
expect(metadata.forTag, contains('foo'));
expect(metadata.forTag['foo'].skip, isTrue);
});
@@ -87,10 +87,38 @@ void main() {
expect(metadata.skip, isTrue);
expect(metadata.skipReason, isNull);
expect(metadata.timeout, equals(Timeout.none));
- expect(metadata.tags, equals(['foo', 'bar', 'baz']));
+ expect(metadata.tags, unorderedEquals(['foo', 'bar', 'baz']));
expect(metadata.forTag.keys, equals(['qux']));
});
+ test("resolves forTags that adds a behavioral tag", () {
+ var metadata = new Metadata(
+ tags: ['foo'],
+ forTag: {
+ 'baz': new Metadata(skip: true),
+ 'bar': new Metadata(verboseTrace: true, tags: ['baz']),
+ 'foo': new Metadata(tags: ['bar'])
+ });
+
+ expect(metadata.verboseTrace, isTrue);
+ expect(metadata.skip, isTrue);
+ expect(metadata.tags, unorderedEquals(['foo', 'bar', 'baz']));
+ expect(metadata.forTag, isEmpty);
+ });
+
+ test("resolves forTags that adds circular tags", () {
+ var metadata = new Metadata(
+ tags: ['foo'],
+ forTag: {
+ 'foo': new Metadata(tags: ['bar']),
+ 'bar': new Metadata(tags: ['baz']),
+ 'baz': new Metadata(tags: ['foo'])
+ });
+
+ expect(metadata.tags, unorderedEquals(['foo', 'bar', 'baz']));
+ expect(metadata.forTag, isEmpty);
+ });
+
test("base metadata takes precedence over forTags", () {
var metadata = new Metadata(
verboseTrace: true,
« no previous file with comments | « lib/src/runner/configuration/load.dart ('k') | test/runner/configuration/tags_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698