Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1285)

Unified Diff: lib/src/runner/configuration/load.dart

Issue 1709633003: Add the ability to add tags in the test config. (Closed) Base URL: git@github.com:dart-lang/test@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/runner/configuration.dart ('k') | test/backend/metadata_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/runner/configuration/load.dart
diff --git a/lib/src/runner/configuration/load.dart b/lib/src/runner/configuration/load.dart
index 212ba34bd3177298df8a5fc70cd5b06408874515..a70fe68914c50708ff4383cc689610691e1ca7e5 100644
--- a/lib/src/runner/configuration/load.dart
+++ b/lib/src/runner/configuration/load.dart
@@ -60,6 +60,15 @@ class _ConfigurationLoader {
var timeout = _parseValue("timeout", (value) => new Timeout.parse(value));
+ var addTags = _getList("add_tags", (tagNode) {
+ _validate(tagNode, "Tags must be strings.", (value) => value is String);
+ _validate(
+ tagNode,
+ "Invalid tag. Tags must be (optionally hyphenated) Dart identifiers.",
+ (value) => value.contains(anchoredHyphenatedIdentifier));
+ return tagNode.value;
+ });
+
var tags = _getMap("tags", key: (keyNode) {
_validate(keyNode, "tags key must be a string.",
(value) => value is String);
@@ -77,6 +86,7 @@ class _ConfigurationLoader {
verboseTrace: verboseTrace,
jsTrace: jsTrace,
timeout: timeout,
+ addTags: addTags,
tags: tags);
}
« no previous file with comments | « lib/src/runner/configuration.dart ('k') | test/backend/metadata_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698