Check scalar to fixed conversions with axes.

src/ports/SkFontHost_FreeType.cpp

 /*
  * Copyright 2006 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkAdvancedTypefaceMetrics.h"
 #include "SkBitmap.h"
 #include "SkCanvas.h"
@@ skipping 1732 matching lines @@
 }
 
 /*static*/ void SkTypeface_FreeType::Scanner::computeAxisValues(
     AxisDefinitions axisDefinitions,
     const SkFontMgr::FontParameters::Axis* requestedAxes, int requestedAxisCount,
     SkFixed* axisValues,
     const SkString& name)
 {
     for (int i = 0; i < axisDefinitions.count(); ++i) {
         const Scanner::AxisDefinition& axisDefinition = axisDefinitions[i];
+        const SkScalar axisMin = SkFixedToScalar(axisDefinition.fMinimum);
+        const SkScalar axisMax = SkFixedToScalar(axisDefinition.fMaximum);
         axisValues[i] = axisDefinition.fDefault;
         for (int j = 0; j < requestedAxisCount; ++j) {
             const SkFontMgr::FontParameters::Axis& axisSpecified = requestedAxes[j];
             if (axisDefinition.fTag == axisSpecified.fTag) {
-                SkFixed axisValue = SkScalarToFixed(axisSpecified.fStyleValue);
-                axisValues[i] = SkTPin(axisValue, axisDefinition.fMinimum, axisDefinition.fMaximum);
-                if (axisValues[i] != axisValue) {
+                const SkScalar axisValue = SkTPin(axisSpecified.fStyleValue, axisMin, axisMax);
+                if (axisSpecified.fStyleValue != axisValue) {
                     SkDEBUGF(("Requested font axis value out of range: "
                               "%s '%c%c%c%c' %f; pinned to %f.\n",
                               name.c_str(),
                               (axisDefinition.fTag >> 24) & 0xFF,
                               (axisDefinition.fTag >> 16) & 0xFF,
                               (axisDefinition.fTag >>  8) & 0xFF,
                               (axisDefinition.fTag      ) & 0xFF,
                               SkScalarToDouble(axisSpecified.fStyleValue),
-                              SkFixedToDouble(axisValues[i])));
+                              SkScalarToDouble(axisValue)));
                 }
+                axisValues[i] = SkScalarToFixed(axisValue);
                 break;
             }
         }
         // TODO: warn on defaulted axis?
     }
 
     SkDEBUGCODE(
         // Check for axis specified, but not matched in font.
         for (int i = 0; i < requestedAxisCount; ++i) {
             SkFourByteTag skTag = requestedAxes[i].fTag;
             bool found = false;
             for (int j = 0; j < axisDefinitions.count(); ++j) {
                 if (skTag == axisDefinitions[j].fTag) {
                     found = true;
                     break;
                 }
             }
             if (!found) {
                 SkDEBUGF(("Requested font axis not found: %s '%c%c%c%c'\n",
                           name.c_str(),
                           (skTag >> 24) & 0xFF,
                           (skTag >> 16) & 0xFF,
                           (skTag >>  8) & 0xFF,
                           (skTag)       & 0xFF));
             }
         }
     )
 }