Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 17094002: Update the TSan-specific atomics implementation to match the current API. (Closed)

Created:
7 years, 6 months ago by Alexander Potapenko
Modified:
7 years, 6 months ago
Reviewers:
Sven Panne, dvyukov, danno, yurys
CC:
v8-dev
Visibility:
Public.

Description

Update the TSan-specific atomics implementation to match the current API. BUG=128314 Committed: https://code.google.com/p/v8/source/detail?r=15279

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+156 lines, -91 lines) Patch
M src/atomicops_internals_tsan.h View 2 chunks +156 lines, -91 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Alexander Potapenko
Dima, can you please take a look? I'll send this CL to the V8 folks ...
7 years, 6 months ago (2013-06-14 15:01:07 UTC) #1
Dmitry Vyukov
On 2013/06/14 15:01:07, Alexander Potapenko wrote: > Dima, can you please take a look? > ...
7 years, 6 months ago (2013-06-14 15:06:33 UTC) #2
Alexander Potapenko
Daniel, can you review this, please?
7 years, 6 months ago (2013-06-14 15:14:02 UTC) #3
danno
Delegating to Sven...
7 years, 6 months ago (2013-06-17 11:01:00 UTC) #4
Sven Panne
LGTM (basically rubber-stamped)
7 years, 6 months ago (2013-06-17 11:09:31 UTC) #5
Alexander Potapenko
On 2013/06/17 11:09:31, Sven Panne wrote: > LGTM (basically rubber-stamped) Oops, completely forgot this is ...
7 years, 6 months ago (2013-06-17 16:04:37 UTC) #6
Alexander Potapenko
Ping?
7 years, 6 months ago (2013-06-24 09:14:41 UTC) #7
yurys
7 years, 6 months ago (2013-06-24 09:23:29 UTC) #8
On 2013/06/24 09:14:41, Alexander Potapenko wrote:
> Ping?

I'll land this.

Powered by Google App Engine
This is Rietveld 408576698