Update the TSan v2 atomic declarations.

Change the TSan v2 memory order constants to match the ones used by TSan runtime library now.
Pull other changes for this file from the LLVM tree
(http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/rtl/tsan_interface_atomic.h?revision=169265&view=markup)

BUG=128314
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172032

[Alexander Potapenko, 2012-12-05 05:24:34]

Dima, PTAL
Should we add any comments to this header?

[Alexander Potapenko, 2012-12-05 05:25:34]

https://codereview.chromium.org/11440006/diff/5001/base/atomicops_internals_t...
File base/atomicops_internals_tsan.h (right):

https://codereview.chromium.org/11440006/diff/5001/base/atomicops_internals_t...
base/atomicops_internals_tsan.h:182: volatile __tsan_atomic8 *a, __tsan_atomic8
c, __tsan_atomic8 v,
Is this really "__tsan_atomic8 c", not "__tsan_atomic8 *c"?

[Dmitry Vyukov, 2012-12-05 06:09:53]

https://codereview.chromium.org/11440006/diff/5001/base/atomicops_internals_t...
File base/atomicops_internals_tsan.h (right):

https://codereview.chromium.org/11440006/diff/5001/base/atomicops_internals_t...
base/atomicops_internals_tsan.h:182: volatile __tsan_atomic8 *a, __tsan_atomic8
c, __tsan_atomic8 v,
On 2012/12/05 05:25:34, Alexander Potapenko wrote:
> Is this really "__tsan_atomic8 c", not "__tsan_atomic8 *c"?

Yes, it is value. The _val functions return old value (similar to
__sync_compare_exchange_val and InterlockCompareExchange).
However, they return __tsan_atomicXXX rather than int.

[Alexander Potapenko, 2012-12-06 18:31:51]

Darin, can you please review this small CL?
I've updated the TSan atomics declarations to match the API declared in LLVM:
http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/rtl/tsan_inter...

[darin (slow to review), 2012-12-06 19:17:50]

If someone with domain expertise could first review the patch and indicate
that it looks good, then I'd be more than happy to apply my rubber stamp.

-Darin


On Thu, Dec 6, 2012 at 10:31 AM, <glider@chromium.org> wrote:

> Darin, can you please review this small CL?
> I've updated the TSan atomics declarations to match the API declared in
> LLVM:
> http://llvm.org/viewvc/llvm-**project/compiler-rt/trunk/lib/**
>
tsan/rtl/tsan_interface_**atomic.h?revision=169265&view=**markup<http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/rtl/tsan_interface_atomic.h?revision=169265&view=markup>
>
>
https://codereview.chromium.**org/11440006/<https://codereview.chromium.org/1...
>

[Dmitry Vyukov, 2012-12-06 19:31:25]

https://codereview.chromium.org/11440006/diff/5001/base/atomicops_internals_t...
File base/atomicops_internals_tsan.h (right):

https://codereview.chromium.org/11440006/diff/5001/base/atomicops_internals_t...
base/atomicops_internals_tsan.h:182: volatile __tsan_atomic8 *a, __tsan_atomic8
c, __tsan_atomic8 v,
On 2012/12/05 06:09:53, Dmitry Vyukov wrote:
> On 2012/12/05 05:25:34, Alexander Potapenko wrote:
> > Is this really "__tsan_atomic8 c", not "__tsan_atomic8 *c"?
> 
> Yes, it is value. The _val functions return old value (similar to
> __sync_compare_exchange_val and InterlockCompareExchange).
> However, they return __tsan_atomicXXX rather than int.

This needs to be addressed.

[Alexander Potapenko, 2012-12-06 19:38:19]

Sorry, I got it wrong. Fixed.

[Dmitry Vyukov, 2012-12-07 04:07:32]

LGTM

[darin (slow to review), 2012-12-07 07:55:26]

LGTM

https://codereview.chromium.org/11440006/diff/12002/base/atomicops_internals_...
File base/atomicops_internals_tsan.h (right):

https://codereview.chromium.org/11440006/diff/12002/base/atomicops_internals_...
base/atomicops_internals_tsan.h:211: __tsan_memory_order_relaxed,
__tsan_memory_order_relaxed);
nit: 4 character indent for line continuation.

[Alexander Potapenko, 2012-12-10 11:11:04]

https://codereview.chromium.org/11440006/diff/12002/base/atomicops_internals_...
File base/atomicops_internals_tsan.h (right):

https://codereview.chromium.org/11440006/diff/12002/base/atomicops_internals_...
base/atomicops_internals_tsan.h:211: __tsan_memory_order_relaxed,
__tsan_memory_order_relaxed);
On 2012/12/07 07:55:27, darin wrote:
> nit: 4 character indent for line continuation.

Done.