Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1709313002: Remove m_pDownloadCallback. (Closed)

Created:
4 years, 10 months ago by Tom Sepez
Modified:
4 years, 10 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove m_pDownloadCallback. Not only unused, but ugly-looking. Fix lint along the way. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/4422dbd49b949a7019294e91edac96c761430e71

Patch Set 1 #

Patch Set 2 : cpplint #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M core/include/fpdfapi/fpdf_module.h View 1 3 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Tom Sepez
Lei, trivial review.
4 years, 10 months ago (2016-02-18 21:42:12 UTC) #3
Lei Zhang
lgtm
4 years, 10 months ago (2016-02-18 21:49:16 UTC) #5
Tom Sepez
4 years, 10 months ago (2016-02-18 21:54:55 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4422dbd49b949a7019294e91edac96c761430e71 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698