Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: core/include/fpdfapi/fpdf_module.h

Issue 1709313002: Remove m_pDownloadCallback. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: cpplint Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/include/fpdfapi/fpdf_module.h
diff --git a/core/include/fpdfapi/fpdf_module.h b/core/include/fpdfapi/fpdf_module.h
index 4856184932075345d56010083412e462dddcc7b8..dffef9606e8bb0cf6e85df476ef2c668880a04ac 100644
--- a/core/include/fpdfapi/fpdf_module.h
+++ b/core/include/fpdfapi/fpdf_module.h
@@ -78,7 +78,6 @@ class CPDF_ModuleMgr {
CCodec_ModuleMgr* m_pCodecModule;
std::unique_ptr<IPDF_RenderModule> m_pRenderModule;
std::unique_ptr<IPDF_PageModule> m_pPageModule;
- FX_BOOL (*m_pDownloadCallback)(const FX_CHAR* module_name);
CFX_PrivateData m_privateData;
};
@@ -87,8 +86,8 @@ class IPDF_PageModule {
virtual ~IPDF_PageModule() {}
virtual CPDF_DocPageData* CreateDocData(CPDF_Document* pDoc) = 0;
- virtual void ReleaseDoc(CPDF_Document*) = 0;
- virtual void ClearDoc(CPDF_Document*) = 0;
+ virtual void ReleaseDoc(CPDF_Document* pDoc) = 0;
+ virtual void ClearDoc(CPDF_Document* pDoc) = 0;
virtual CPDF_FontGlobals* GetFontGlobals() = 0;
virtual void ClearStockFont(CPDF_Document* pDoc) = 0;
virtual void NotifyCJKAvailable() = 0;
@@ -100,11 +99,11 @@ class IPDF_RenderModule {
virtual ~IPDF_RenderModule() {}
virtual CPDF_DocRenderData* CreateDocData(CPDF_Document* pDoc) = 0;
- virtual void DestroyDocData(CPDF_DocRenderData*) = 0;
- virtual void ClearDocData(CPDF_DocRenderData*) = 0;
+ virtual void DestroyDocData(CPDF_DocRenderData* pDocRenderData) = 0;
+ virtual void ClearDocData(CPDF_DocRenderData* pDocRenderData) = 0;
virtual CPDF_DocRenderData* GetRenderData() = 0;
virtual CPDF_PageRenderCache* CreatePageCache(CPDF_Page* pPage) = 0;
- virtual void DestroyPageCache(CPDF_PageRenderCache*) = 0;
+ virtual void DestroyPageCache(CPDF_PageRenderCache* pCache) = 0;
};
#endif // CORE_INCLUDE_FPDFAPI_FPDF_MODULE_H_
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698