Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(906)

Issue 1709133003: Revert of Use unorm shorts for texture coordinates when rendering text. (Closed)

Created:
4 years, 10 months ago by jvanverth1
Modified:
4 years, 10 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Use unorm shorts for texture coordinates when rendering text. (patchset #3 id:40001 of https://codereview.chromium.org/1713693002/ ) Reason for revert: Causing issues with text on Mali 400s. Examples: largeglyphblur, imageblurtiled. It appears that there are precision problems. Original issue's description: > Use unorm shorts for texture coordinates when rendering text. > > There are a couple of reasons for this: > - Vulkan does not guarantee conversions from integral vertex attributes > to floating point shader variables > - This may be faster and more precise on some platforms, as it avoids > the aforementioned conversion and changes a multiply by a very small > value to a multiply by a medium-sized value. > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1713693002 > TBR=bsalomon@google.com > > Committed: https://skia.googlesource.com/skia/+/e507ff0460f4f878214b9454fb5b9ab8d64d8063 TBR=joshualitt@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/d106c2c64012688f8d1439543d942f8f66a142e0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -77 lines) Patch
M include/gpu/GrTypesPriv.h View 6 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/GrBatchAtlas.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/GrTest.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.cpp View 2 chunks +7 lines, -3 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.cpp View 4 chunks +24 lines, -18 lines 0 comments Download
M src/gpu/gl/GrGLVertexArray.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/text/GrAtlasTextBlob_regenInBatch.cpp View 9 chunks +9 lines, -31 lines 0 comments Download
M src/gpu/text/GrBatchFontCache.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/gpu/text/GrBatchFontCache.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jvanverth1
Created Revert of Use unorm shorts for texture coordinates when rendering text.
4 years, 10 months ago (2016-02-19 16:42:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1709133003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1709133003/1
4 years, 10 months ago (2016-02-19 16:43:08 UTC) #2
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 16:43:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d106c2c64012688f8d1439543d942f8f66a142e0

Powered by Google App Engine
This is Rietveld 408576698