Add additional cellular-related properties to Network|DeviceState

chromeos/network/network_state.h

Index: chromeos/network/network_state.h
diff --git a/chromeos/network/network_state.h b/chromeos/network/network_state.h
index e87cba6bf020de743bd684e1ea84659a0eb9cd43..4ce67319b3b2672f25bd3898ef712488a9eb2b26 100644
--- a/chromeos/network/network_state.h
+++ b/chromeos/network/network_state.h
@@ -67,6 +67,10 @@ class CHROMEOS_EXPORT NetworkState : public ManagedState {
     return activate_over_non_cellular_networks_;
   }
   bool cellular_out_of_credits() const { return cellular_out_of_credits_; }
+  const std::string& usage_url() const { return usage_url_; }
+  const std::string& payment_url() const { return payment_url_; }
+  const std::string& post_method() const { return post_method_; }
+  const std::string& post_data() const { return post_data_; }

[stevenjb, 2013/06/21 01:15:11]

Ugh, do we really need instant access to all of these, or can we use
NetworkConfigurationHandler::GetProperties() instead? I know that I have been
guilty of letting this class bloat, and I'm OK with us doing that during the
transition (as long as we go back and clean these up a bit later), but if making
an asynchronous GetProperties() call doesn't add too much complexity, that would
be preferable.

[gauravsh, 2013/06/21 01:51:09]

In this particular case, yes, it is preferable to allow direct access to these
properties while we transition.

Given MobileActivator's lack of test coverage, I'd like to keep the changes to
it as minimal as possible. Once we move over to using NetworkingPrivate API for
the activation code, I suspect async GetProperties would fit very well within
the JS way of doing thing.

I filed a TODO bug.

[stevenjb, 2013/06/21 20:28:53]

OK, fair enough.

 
   bool IsConnectedState() const;
   bool IsConnectingState() const;
@@ -130,6 +134,11 @@ class CHROMEOS_EXPORT NetworkState : public ManagedState {
   std::string roaming_;
   bool activate_over_non_cellular_networks_;
   bool cellular_out_of_credits_;
+  // Cellular payment portal properties.
+  std::string usage_url_;
+  std::string payment_url_;
+  std::string post_method_;
+  std::string post_data_;
 
   DISALLOW_COPY_AND_ASSIGN(NetworkState);
 };