Add additional cellular-related properties to Network|DeviceState

chromeos/network/network_state.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_NETWORK_NETWORK_STATE_H_
 #define CHROMEOS_NETWORK_NETWORK_STATE_H_
 
 #include <string>
 #include <vector>
 
@@ skipping 49 matching lines @@
   // Wifi property accessors
   bool passphrase_required() const { return passphrase_required_; }
   // Cellular property accessors
   const std::string& technology() const { return technology_; }
   const std::string& activation_state() const { return activation_state_; }
   const std::string& roaming() const { return roaming_; }
   bool activate_over_non_cellular_networks() const {
     return activate_over_non_cellular_networks_;
   }
   bool cellular_out_of_credits() const { return cellular_out_of_credits_; }
+  const std::string& usage_url() const { return usage_url_; }
+  const std::string& payment_url() const { return payment_url_; }
+  const std::string& post_method() const { return post_method_; }
+  const std::string& post_data() const { return post_data_; }

[stevenjb, 2013/06/21 01:15:11]

Ugh, do we really need instant access to all of these, or can we use
NetworkConfigurationHandler::GetProperties() instead? I know that I have been
guilty of letting this class bloat, and I'm OK with us doing that during the
transition (as long as we go back and clean these up a bit later), but if making
an asynchronous GetProperties() call doesn't add too much complexity, that would
be preferable.

[gauravsh, 2013/06/21 01:51:09]

In this particular case, yes, it is preferable to allow direct access to these
properties while we transition.

Given MobileActivator's lack of test coverage, I'd like to keep the changes to
it as minimal as possible. Once we move over to using NetworkingPrivate API for
the activation code, I suspect async GetProperties would fit very well within
the JS way of doing thing.

I filed a TODO bug.

[stevenjb, 2013/06/21 20:28:53]

OK, fair enough.

 
   bool IsConnectedState() const;
   bool IsConnectingState() const;
 
   // Returns true if |error_| contains an authentication error.
   bool HasAuthenticationError() const;
 
   // Helpers (used e.g. when a state is cached)
   static bool StateIsConnected(const std::string& connection_state);
   static bool StateIsConnecting(const std::string& connection_state);
@@ skipping 43 matching lines @@
   // Wifi properties
   std::string hex_ssid_;
   std::string country_code_;
   bool passphrase_required_;
   // Cellular properties
   std::string technology_;
   std::string activation_state_;
   std::string roaming_;
   bool activate_over_non_cellular_networks_;
   bool cellular_out_of_credits_;
+  // Cellular payment portal properties.
+  std::string usage_url_;
+  std::string payment_url_;
+  std::string post_method_;
+  std::string post_data_;
 
   DISALLOW_COPY_AND_ASSIGN(NetworkState);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROMEOS_NETWORK_NETWORK_STATE_H_