Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 17090005: [CSS Grid Layout] Implement 'justify-self' parsing (Closed)

Created:
7 years, 6 months ago by Julien - ping for review
Modified:
6 years, 11 months ago
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears
Visibility:
Public.

Description

[CSS Grid Layout] Implement 'justify-self' parsing This change adds the property from CSS 3 Box Alignment and implements the parsing. For now, the property is protected by the CSS Grid Layout runtime flag as it is the only consumer but we may have to introduce a new flag for the other layouts (block, flex, ...) as defined by the Alignment spec. This change also fixes a bug uncovered in color parsing code, where we would consider invalid colors as valid system colors. BUG=249451 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164685

Patch Set 1 #

Patch Set 2 : Added justify-self to webexposed and fixed a bug in the system color parsing uncovered by this chan… #

Patch Set 3 : Scrubbed and rebaselined patch #

Total comments: 2

Patch Set 4 : Rebaselined patch. #

Patch Set 5 : Rebaselined patch #

Patch Set 6 : Fixed a bug in parseColor uncovered by the patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+557 lines, -5 lines) Patch
A LayoutTests/fast/alignment/parse-justify-self.html View 1 2 1 chunk +232 lines, -0 lines 0 comments Download
A LayoutTests/fast/alignment/parse-justify-self-expected.txt View 1 2 3 1 chunk +61 lines, -0 lines 0 comments Download
M LayoutTests/webexposed/css-properties-as-js-properties-expected.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 2 3 4 2 chunks +8 lines, -0 lines 0 comments Download
M Source/core/css/CSSPrimitiveValueMappings.h View 1 2 3 4 1 chunk +109 lines, -0 lines 0 comments Download
M Source/core/css/CSSProperty.cpp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/CSSPropertyNames.in View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/CSSValueKeywords.in View 1 2 3 4 1 chunk +16 lines, -0 lines 0 comments Download
M Source/core/css/RuntimeCSSEnabled.cpp View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/css/parser/BisonCSSParser.h View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/css/parser/BisonCSSParser-in.cpp View 1 2 3 4 5 5 chunks +71 lines, -2 lines 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 1 2 3 4 2 chunks +13 lines, -0 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/rendering/style/RenderStyle.h View 1 2 3 4 3 chunks +6 lines, -0 lines 0 comments Download
M Source/core/rendering/style/RenderStyleConstants.h View 1 2 3 4 1 chunk +21 lines, -0 lines 0 comments Download
M Source/core/rendering/style/StyleRareNonInheritedData.h View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/rendering/style/StyleRareNonInheritedData.cpp View 1 2 3 3 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 21 (0 generated)
Julien - ping for review
7 years, 6 months ago (2013-06-14 17:51:07 UTC) #1
Julien - ping for review
This patch is based on the Working Draft of the Alignment specification. While updating it ...
7 years, 6 months ago (2013-06-19 23:33:22 UTC) #2
Julien - ping for review
> In the meantime, don't waste your time reviewing the change! The time has come ...
7 years, 1 month ago (2013-11-12 00:27:59 UTC) #3
Julien - ping for review
@ojan / @darktears: Review ping, this is blocking adding more alignment properties as they all ...
7 years, 1 month ago (2013-11-18 04:25:11 UTC) #4
ojan
lgtm justify-content also takes the second bool value (not currently implemented). Would be nice if ...
7 years ago (2013-11-25 21:24:07 UTC) #5
Julien - ping for review
> justify-content also takes the second bool value (not currently implemented). > Would be nice ...
7 years ago (2013-11-26 00:08:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/17090005/152001
7 years ago (2013-12-05 05:07:42 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=14617
7 years ago (2013-12-05 06:22:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/17090005/152001
7 years ago (2013-12-06 22:41:03 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=14817
7 years ago (2013-12-07 01:00:29 UTC) #10
Julien - ping for review
The 2 unit tests failing (and preventing this change from landing) are fragile: they assume ...
7 years ago (2013-12-07 02:44:35 UTC) #11
mithro-old
On 2013/12/07 02:44:35, Julien Chaffraix - PST wrote: > +Mithro who wrote > AnimationCompositorAnimationsTest.isCandidateForAnimationOnCompositorKeyframeMultipleCSSProperties. Expected: ...
7 years ago (2013-12-08 23:34:28 UTC) #12
dstockwell
On 2013/12/08 23:34:28, mithro wrote: > On 2013/12/07 02:44:35, Julien Chaffraix - PST wrote: > ...
7 years ago (2013-12-08 23:57:43 UTC) #13
mithro-old
On 2013/12/08 23:57:43, dstockwell wrote: > On 2013/12/08 23:34:28, mithro wrote: > > On 2013/12/07 ...
7 years ago (2013-12-08 23:59:59 UTC) #14
dstockwell
On 2013/12/08 23:59:59, mithro wrote: > On 2013/12/08 23:57:43, dstockwell wrote: > > On 2013/12/08 ...
7 years ago (2013-12-09 00:12:16 UTC) #15
mithro-old
On 2013/12/09 00:12:16, dstockwell wrote: > On 2013/12/08 23:59:59, mithro wrote: > > On 2013/12/08 ...
7 years ago (2013-12-09 00:19:59 UTC) #16
Steve Block
> +Steve who wrote AnimationKeyframeAnimationEffectTest.MultipleProperties. Sorry about this. Fix pending in https://codereview.chromium.org/111683005/
7 years ago (2013-12-16 02:49:40 UTC) #17
Julien - ping for review
On 2013/12/16 02:49:40, Steve Block wrote: > > +Steve who wrote AnimationKeyframeAnimationEffectTest.MultipleProperties. > Sorry about ...
7 years ago (2013-12-18 21:05:41 UTC) #18
Julien - ping for review
On 2013/12/18 21:05:41, Julien Chaffraix - CET wrote: > On 2013/12/16 02:49:40, Steve Block wrote: ...
7 years ago (2013-12-20 10:02:27 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/17090005/212001
6 years, 11 months ago (2014-01-08 15:02:39 UTC) #20
commit-bot: I haz the power
6 years, 11 months ago (2014-01-08 15:14:43 UTC) #21
Message was sent while issue was closed.
Change committed as 164685

Powered by Google App Engine
This is Rietveld 408576698