Issue 115403003: Fix isCandidateForAnimationOnCompositorKeyframeMultipleCSSProperties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115403003: Fix isCandidateForAnimationOnCompositorKeyframeMultipleCSSProperties (Closed)

Created:
7 years ago by Julien - ping for review

Modified:
6 years, 11 months ago

Reviewers:
dstockwell, mithro-old

CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Fix isCandidateForAnimationOnCompositorKeyframeMultipleCSSProperties The test is super fragile as it relies on the value of some CSSPropertyID which will change as people add more properties. We unfortunately can't use some fixed values as it relies on using a supported property whose CSSPropertyID will evolve over time. This change just reverts the test to its state before: https://codereview.chromium.org/68173013 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164661

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -13 lines)			Patch
	M	Source/core/animation/CompositorAnimationsTest.cpp	View		1 chunk	+3 lines, -13 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jchaffraix@chromium.org/115403003/1

6 years, 11 months ago (2014-01-08 04:58:42 UTC) #4

Message was sent while issue was closed.

Change committed as 164661

Expand Messages | Collapse Messages