Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 1708973002: Add a useful error message for run-webkit-tests broken --target handling. (Closed)

Created:
4 years, 10 months ago by Dirk Pranke
Modified:
4 years, 10 months ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a useful error message for run-webkit-tests broken --target handling. This will hopefully prevent some wasted time until the underlying problem is fixed. R=kbr@chromium.org, skobes@chromium.org BUG=539509 Committed: https://crrev.com/afd25fb38db90dea1058240aceb6bbc02578f947 Cr-Commit-Position: refs/heads/master@{#376092}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Dirk Pranke
4 years, 10 months ago (2016-02-18 03:29:16 UTC) #1
skobes
lgtm
4 years, 10 months ago (2016-02-18 03:31:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1708973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1708973002/1
4 years, 10 months ago (2016-02-18 03:35:06 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-18 04:26:50 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/afd25fb38db90dea1058240aceb6bbc02578f947 Cr-Commit-Position: refs/heads/master@{#376092}
4 years, 10 months ago (2016-02-18 04:28:18 UTC) #7
dstockwell
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1714773002/ by dstockwell@chromium.org. ...
4 years, 10 months ago (2016-02-19 03:02:10 UTC) #8
alancutter (OOO until 2018)
4 years, 10 months ago (2016-02-19 03:36:29 UTC) #9
Message was sent while issue was closed.
On 2016/02/19 at 03:02:10, dstockwell wrote:
> A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1714773002/ by dstockwell@chromium.org.
> 
> The reason for reverting is: Broke workflows not using the "blessed" output
directories.
> 
> See: https://codereview.chromium.org/1705233003#msg6.

It would also break the "blessed" out/Default GN workflow.

Powered by Google App Engine
This is Rietveld 408576698