Issue 1708903002: Subzero. ARM32. Enable more crosstests.

Issue 1708903002: Subzero. ARM32. Enable more crosstests. (Closed)

Created:
4 years, 10 months ago by Eric Holk

Modified:
4 years, 10 months ago

Reviewers:
kschimpf, sehr, Karl, Jim Stichnoth, John

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Subzero. ARM32. Enable more crosstests. This removes most of the #ifndef ARM32 directives so we get more thorough testing. It still uses fewer iterations due to running on Qemu, but I did manually check to be sure that the tests pass without any special casing at all. BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4076 R=jpp@chromium.org, kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=6d392374d85af25abb7192eeaaeddc489ee819ba

Created: 4 years, 10 months ago

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -24 lines)
M	crosstest/test_arith_main.cpp	View	4 chunks	+0 lines, -6 lines	0 comments
M	crosstest/test_calling_conv.cpp	View	3 chunks	+0 lines, -6 lines	0 comments
M	crosstest/test_cast_main.cpp	View	2 chunks	+0 lines, -3 lines	0 comments
M	crosstest/test_fcmp_main.cpp	View	2 chunks	+0 lines, -3 lines	0 comments
M	crosstest/test_icmp_main.cpp	View	4 chunks	+0 lines, -6 lines	0 comments

Total messages: 12 (3 generated)

Eric Holk

Oops, I forgot to save some of the files with changes in them. I'll upload ...

4 years, 10 months ago (2016-02-17 23:15:52 UTC) #7

Eric Holk

I added the files I forgot about last time. Hopefully this still lgtm.

4 years, 10 months ago (2016-02-17 23:40:40 UTC) #8

Eric Holk

Committed patchset #2 (id:20001) manually as 6d392374d85af25abb7192eeaaeddc489ee819ba (presubmit successful).

4 years, 10 months ago (2016-02-17 23:47:26 UTC) #11

Message was sent while issue was closed.

Sweet!!! LGTM