Issue 17089003: Optimized test output checking - avoid redundant checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17089003: Optimized test output checking - avoid redundant checks. (Closed)

Created:
7 years, 6 months ago by Michael Achenbach

Modified:
7 years, 6 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

HasUnexpectedOutput() is evaluated two times for each test run. This fix removes the redundant call to allow heavy text comparisons through overwriting of that method. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15162

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -16 lines)			Patch
M	tools/testrunner/local/execution.py	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	tools/testrunner/local/progress.py	View	5 chunks	+10 lines, -10 lines	0 comments	Download
M	tools/testrunner/network/endpoint.py	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/testrunner/network/network_execution.py	View	1 chunk	+3 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

Michael Achenbach

7 years, 6 months ago (2013-06-14 14:57:23 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r15162 (presubmit successful).