Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: tools/testrunner/network/network_execution.py

Issue 17089003: Optimized test output checking - avoid redundant checks. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/testrunner/network/endpoint.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testrunner/network/network_execution.py
diff --git a/tools/testrunner/network/network_execution.py b/tools/testrunner/network/network_execution.py
index ddb59e60b787426cd081d5a46f4380e36eb384f2..0f53a6bb645bf2a757948e7656e6817a124349e8 100644
--- a/tools/testrunner/network/network_execution.py
+++ b/tools/testrunner/network/network_execution.py
@@ -204,14 +204,15 @@ class NetworkedRunner(execution.Runner):
self.context.arch, self.context.mode],
self.local_socket)
self.indicator.AboutToRun(test)
- if test.suite.HasUnexpectedOutput(test):
+ has_unexpected_output = test.suite.HasUnexpectedOutput(test)
+ if has_unexpected_output:
self.failed.append(test)
if test.output.HasCrashed():
self.crashed += 1
else:
self.succeeded += 1
self.remaining -= 1
- self.indicator.HasRun(test)
+ self.indicator.HasRun(test, has_unexpected_output)
rec.Advance()
peer.runtime = time.time() - start_time
except KeyboardInterrupt:
« no previous file with comments | « tools/testrunner/network/endpoint.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698