base/BUILD.gn - Issue 1708763003: Fix strict mode violation in TabPersistentStore.cleanupPersistentData()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/BUILD.gn

Issue 1708763003: Fix strict mode violation in TabPersistentStore.cleanupPersistentData() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tab-persist-1

Patch Set: fix test, address commetns Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/BUILD.gn

diff --git a/base/BUILD.gn b/base/BUILD.gn

index f6e2e72c08238ce819bd165d284d25099b7107e7..4c72a524b1e9827472602133aad21cdad4e8cf7e 100644

--- a/base/BUILD.gn

+++ b/base/BUILD.gn

@@ -1997,6 +1997,7 @@ if (is_android) {

deps = [

"//third_party/android_tools:android_support_multidex_java",

+ "//third_party/android_tools:android_support_v13_java",

gone 2016/02/18 17:09:13 Yeah, I've tried this before. I think newt@ said

agrieve 2016/02/23 21:28:38 Removing from this patch, but might re-visit on it

"//third_party/jsr-305:jsr_305_javalib",

]

« no previous file with comments | « no previous file | base/android/java/src/org/chromium/base/PathUtils.java » ('j') | base/android/java/src/org/chromium/base/PathUtils.java » ('J')