Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: base/BUILD.gn

Issue 1708763003: Fix strict mode violation in TabPersistentStore.cleanupPersistentData() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@tab-persist-1
Patch Set: fix test, address commetns Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # HOW TO WRITE CONDITIONALS IN THIS FILE 5 # HOW TO WRITE CONDITIONALS IN THIS FILE
6 # ====================================== 6 # ======================================
7 # 7 #
8 # In many other places, one would write a conditional that expresses all the 8 # In many other places, one would write a conditional that expresses all the
9 # cases when a source file is used or unused, and then either add or subtract 9 # cases when a source file is used or unused, and then either add or subtract
10 # it from the sources list in that case 10 # it from the sources list in that case
(...skipping 1979 matching lines...) Expand 10 before | Expand all | Expand 10 after
1990 # GYP: //base.gyp:base_java 1990 # GYP: //base.gyp:base_java
1991 android_library("base_java") { 1991 android_library("base_java") {
1992 srcjar_deps = [ 1992 srcjar_deps = [
1993 ":base_android_java_enums_srcjar", 1993 ":base_android_java_enums_srcjar",
1994 ":base_build_config_gen", 1994 ":base_build_config_gen",
1995 ":base_native_libraries_gen", 1995 ":base_native_libraries_gen",
1996 ] 1996 ]
1997 1997
1998 deps = [ 1998 deps = [
1999 "//third_party/android_tools:android_support_multidex_java", 1999 "//third_party/android_tools:android_support_multidex_java",
2000 "//third_party/android_tools:android_support_v13_java",
gone 2016/02/18 17:09:13 Yeah, I've tried this before. I think newt@ said
agrieve 2016/02/23 21:28:38 Removing from this patch, but might re-visit on it
2000 "//third_party/jsr-305:jsr_305_javalib", 2001 "//third_party/jsr-305:jsr_305_javalib",
2001 ] 2002 ]
2002 2003
2003 DEPRECATED_java_in_dir = "android/java/src" 2004 DEPRECATED_java_in_dir = "android/java/src"
2004 2005
2005 # New versions of BuildConfig.java and NativeLibraries.java 2006 # New versions of BuildConfig.java and NativeLibraries.java
2006 # (with the actual correct values) will be created when creating an apk. 2007 # (with the actual correct values) will be created when creating an apk.
2007 jar_excluded_patterns = [ 2008 jar_excluded_patterns = [
2008 "*/BuildConfig.class", 2009 "*/BuildConfig.class",
2009 "*/NativeLibraries.class", 2010 "*/NativeLibraries.class",
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
2088 2089
2089 # GYP: //base.gyp:base_java_unittest_support 2090 # GYP: //base.gyp:base_java_unittest_support
2090 android_library("base_java_unittest_support") { 2091 android_library("base_java_unittest_support") {
2091 deps = [ 2092 deps = [
2092 ":base_java", 2093 ":base_java",
2093 ] 2094 ]
2094 java_files = 2095 java_files =
2095 [ "test/android/java/src/org/chromium/base/ContentUriTestUtils.java" ] 2096 [ "test/android/java/src/org/chromium/base/ContentUriTestUtils.java" ]
2096 } 2097 }
2097 } 2098 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698