Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1708733002: ui: Fix TEXTURE_RECTANGLE support in GLImage unit tests. (Closed)

Created:
4 years, 10 months ago by reveman
Modified:
4 years, 10 months ago
Reviewers:
Daniele Castagna, piman
CC:
chromium-reviews, erikchen
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ui: Fix TEXTURE_RECTANGLE support in GLImage unit tests. Sampling from texture with TEXTURE_RECTANGLE target requires unnormalized texture coordinates. Prior to this change all texture sampling would be done from a single texel instead of the whole texture when using TEXTURE_RECTANGLE target. This change also includes some cleanups to make GLImage unit test code more consistent. BUG= TEST=gl_unittests --gtest_filter=GLImage* Committed: https://crrev.com/b0e9fa1995c48896fb64499ce71768e90a8f7775 Cr-Commit-Position: refs/heads/master@{#375993}

Patch Set 1 #

Patch Set 2 : update OWNERs file to inlcude gl_image test files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -74 lines) Patch
M ui/gl/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/test/gl_image_test_template.h View 5 chunks +77 lines, -73 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
reveman
4 years, 10 months ago (2016-02-17 19:46:11 UTC) #2
Daniele Castagna
lgtm
4 years, 10 months ago (2016-02-17 19:55:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1708733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1708733002/1
4 years, 10 months ago (2016-02-17 19:59:35 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/146980)
4 years, 10 months ago (2016-02-17 20:18:35 UTC) #7
reveman
+piman for ui/gl/OWNERS
4 years, 10 months ago (2016-02-17 20:28:01 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1708733002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1708733002/20001
4 years, 10 months ago (2016-02-17 20:34:30 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-17 21:28:17 UTC) #13
piman
lgtm
4 years, 10 months ago (2016-02-17 21:41:34 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1708733002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1708733002/20001
4 years, 10 months ago (2016-02-17 21:46:05 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-17 21:58:21 UTC) #18
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 21:59:41 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b0e9fa1995c48896fb64499ce71768e90a8f7775
Cr-Commit-Position: refs/heads/master@{#375993}

Powered by Google App Engine
This is Rietveld 408576698