Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 170863002: Revert of Fix posix IPC channel hanging problem. (Closed)

Created:
6 years, 10 months ago by hubbe
Modified:
6 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Fix posix IPC channel hanging problem. (https://codereview.chromium.org/150893002/) Reason for revert: https://crash.corp.google.com/samples?q=reportid=%2702eaaf63ed6fdda9%27 https://crash.corp.google.com/samples?q=reportid=%272ac5bc4dd7c49ced%27 Original issue's description: > Fix posix IPC channel hanging problem. > > If a channel closes right before a send call, listeners might not be notified of > the problem, which can cause hangs. This CL fixes that and adds a test that makes > sure that this does not happen in the future. > > This is cl/30133002 + a memory leak fix. > > BUG=338709 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250964 TBR=shess@chromium.org,cpu@chromium.org,hubbe@google.com NOTREECHECKS=true NOTRY=true BUG=338709 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251791

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -66 lines) Patch
M ipc/ipc_channel_posix.cc View 4 chunks +3 lines, -16 lines 0 comments Download
M ipc/ipc_channel_posix_unittest.cc View 4 chunks +3 lines, -50 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hubbe
Created Revert of Fix posix IPC channel hanging problem.
6 years, 10 months ago (2014-02-18 17:41:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hubbe@chromium.org/170863002/1
6 years, 10 months ago (2014-02-18 17:42:08 UTC) #2
commit-bot: I haz the power
Change committed as 251791
6 years, 10 months ago (2014-02-18 17:42:22 UTC) #3
Fredrik Öhrn
On 2014/02/18 17:41:45, hubbe wrote: > Created Revert of Fix posix IPC channel hanging problem. ...
6 years, 10 months ago (2014-02-19 08:22:52 UTC) #4
hubbe
6 years, 10 months ago (2014-02-19 18:51:44 UTC) #5
Message was sent while issue was closed.
On 2014/02/19 08:22:52, Fredrik Öhrn wrote:
> On 2014/02/18 17:41:45, hubbe wrote:
> > Created Revert of Fix posix IPC channel hanging problem.
> 
> I can't read the links, can you please elaborate why it was reverted?

Basically, calling OnChannelError() from Send() was a bad idea.
OnChannelErorr() will sometimes tear down the entire environment, so when you
return from Send(), bad things happen.

I have a potentially better fix in https://codereview.chromium.org/172773002,
which delays closing the pipe until it is safe to do so.

Powered by Google App Engine
This is Rietveld 408576698