Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 172773002: Fix posix IPC channel hanging problem, take 3 (Closed)

Created:
6 years, 10 months ago by hubbe
Modified:
6 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix posix IPC channel hanging problem. If a channel closes right before a send call, listeners might not be notified of the problem, which can cause hangs. This CL fixes that and adds a test that makes sure that this does not happen in the future. This is similar to cl/150893002, but takes a slightly different approach to how to make sure everything happens in the right order. In particular, it avoids closing the socket (and calling OnChannelError()) from Send(). BUG=338709 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252430

Patch Set 1 #

Patch Set 2 : removed an extra include #

Patch Set 3 : removed an extra include #

Patch Set 4 : removed change that is not needed anymore #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -10 lines) Patch
M ipc/ipc_channel_posix.cc View 1 2 3 3 chunks +8 lines, -4 lines 0 comments Download
M ipc/ipc_channel_posix_unittest.cc View 5 chunks +53 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hubbe
6 years, 10 months ago (2014-02-19 18:58:47 UTC) #1
cpu_(ooo_6.6-7.5)
nice. lgtm
6 years, 10 months ago (2014-02-19 20:17:51 UTC) #2
Scott Hess - ex-Googler
LGTM. My understanding is that in the Send() failure case, the caller gets an error, ...
6 years, 10 months ago (2014-02-19 20:51:31 UTC) #3
hubbe
The CQ bit was checked by hubbe@chromium.org
6 years, 10 months ago (2014-02-20 20:16:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hubbe@chromium.org/172773002/160001
6 years, 10 months ago (2014-02-20 20:19:54 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-21 00:18:31 UTC) #6
Message was sent while issue was closed.
Change committed as 252430

Powered by Google App Engine
This is Rietveld 408576698