Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1708483002: Revert of Make IP Address related functions return the empty string when used on an invalid address. (Closed)

Created:
4 years, 10 months ago by henrika (OOO until Aug 14)
Modified:
4 years, 10 months ago
Reviewers:
martijnc, Nico, eroman
CC:
cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make IP Address related functions return the empty string when used on an invalid address. (patchset #2 id:60001 of https://codereview.chromium.org/1692353002/ ) Reason for revert: Suspect that this patch breaks some net_unittests. See e.g https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/11834/steps/net_unittests Original issue's description: > Make IP Address related functions return the empty string when used on an invalid address. > > BUG=496258 > > Committed: https://crrev.com/c925513a3212a55d9c56bec2eea2058c47a76612 > Cr-Commit-Position: refs/heads/master@{#375701} TBR=eroman@chromium.org,thakis@chromium.org,martijn@martijnc.be # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=496258 Committed: https://crrev.com/260d933af1db1044f651515ee597df74d6236b7d Cr-Commit-Position: refs/heads/master@{#375834}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -39 lines) Patch
M net/base/ip_address.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/base/ip_address_number.h View 1 chunk +2 lines, -4 lines 0 comments Download
M net/base/ip_address_number.cc View 2 chunks +1 line, -3 lines 0 comments Download
M net/base/ip_address_number_unittest.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M net/base/ip_address_unittest.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M net/base/ip_endpoint.h View 1 chunk +3 lines, -4 lines 0 comments Download
M net/base/ip_endpoint_unittest.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
henrika (OOO until Aug 14)
Created Revert of Make IP Address related functions return the empty string when used on ...
4 years, 10 months ago (2016-02-17 08:58:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1708483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1708483002/1
4 years, 10 months ago (2016-02-17 08:59:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-17 09:00:23 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/260d933af1db1044f651515ee597df74d6236b7d Cr-Commit-Position: refs/heads/master@{#375834}
4 years, 10 months ago (2016-02-17 09:01:32 UTC) #6
eroman
4 years, 10 months ago (2016-02-17 16:04:58 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698