Revert of Make IP Address related functions return the empty string when used on an invalid address.

net/base/ip_address_unittest.cc

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/base/ip_address.h"
 
 #include <vector>
 
 #include "base/strings/string_number_conversions.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 76 matching lines @@
   IPAddress ip_address1(addr1);
   EXPECT_EQ("0.0.0.0", ip_address1.ToString());
 
   uint8_t addr2[4] = {192, 168, 0, 1};
   IPAddress ip_address2(addr2);
   EXPECT_EQ("192.168.0.1", ip_address2.ToString());
 
   uint8_t addr3[16] = {0xFE, 0xDC, 0xBA, 0x98};
   IPAddress ip_address3(addr3);
   EXPECT_EQ("fedc:ba98::", ip_address3.ToString());
-
-  // ToString() shouldn't crash on invalid addresses.
-  uint8_t addr4[2];
-  IPAddress ip_address4(addr4);
-  EXPECT_EQ("", ip_address4.ToString());
-
-  IPAddress ip_address5;
-  EXPECT_EQ("", ip_address5.ToString());
 }
 
 // Test that invalid IP literals fail to parse.
 TEST(IPAddressTest, AssignFromIPLiteral_FailParse) {
   IPAddress address;
 
   EXPECT_FALSE(address.AssignFromIPLiteral("bad value"));
   EXPECT_FALSE(address.AssignFromIPLiteral("bad:value"));
   EXPECT_FALSE(address.AssignFromIPLiteral(std::string()));
   EXPECT_FALSE(address.AssignFromIPLiteral("192.168.0.1:30"));
@@ skipping 64 matching lines @@
   EXPECT_TRUE(address1.AssignFromIPLiteral("0.0.0.0"));
   EXPECT_EQ("0.0.0.0:3", IPAddressToStringWithPort(address1, 3));
 
   IPAddress address2;
   EXPECT_TRUE(address2.AssignFromIPLiteral("192.168.0.1"));
   EXPECT_EQ("192.168.0.1:99", IPAddressToStringWithPort(address2, 99));
 
   IPAddress address3;
   EXPECT_TRUE(address3.AssignFromIPLiteral("fedc:ba98::"));
   EXPECT_EQ("[fedc:ba98::]:8080", IPAddressToStringWithPort(address3, 8080));
-
-  // ToString() shouldn't crash on invalid addresses.
-  IPAddress address4;
-  EXPECT_EQ("", IPAddressToStringWithPort(address4, 8080));
 }
 
 TEST(IPAddressTest, IPAddressToPackedString) {
   IPAddress ipv4_address;
   EXPECT_TRUE(ipv4_address.AssignFromIPLiteral("4.31.198.44"));
   std::string expected_ipv4_address("\x04\x1f\xc6\x2c", 4);
   EXPECT_EQ(expected_ipv4_address, IPAddressToPackedString(ipv4_address));
 
   IPAddress ipv6_address;
   EXPECT_TRUE(ipv6_address.AssignFromIPLiteral("2001:0700:0300:1800::000f"));
@@ skipping 21 matching lines @@
   IPAddress expected;
   EXPECT_TRUE(expected.AssignFromIPLiteral("192.168.0.1"));
 
   IPAddress result = ConvertIPv4MappedIPv6ToIPv4(ipv4mapped_address);
   EXPECT_EQ(expected, result);
 }
 
 }  // anonymous namespace
 
 }  // namespace net