Issue 17084007: Revert "GTTF: Remove message loop hooks from TestLauncherDelegate"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17084007: Revert "GTTF: Remove message loop hooks from TestLauncherDelegate" (Closed)

Created:
7 years, 6 months ago by Paweł Hajdan Jr.

Modified:
7 years, 6 months ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Revert "GTTF: Remove message loop hooks from TestLauncherDelegate" > GTTF: Remove message loop hooks from TestLauncherDelegate > > This is a step toward moving TestLauncher to base/test . > > BUG=236893 > R=sky@chromium.org > > Review URL: https://codereview.chromium.org/15808008 Conflicts: chrome/test/base/chrome_test_launcher.cc TBR=jam BUG=236893 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206451

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -41 lines)			Patch
M	chrome/test/base/chrome_test_launcher.cc	View	4 chunks	+2 lines, -13 lines	0 comments	Download
M	content/public/test/test_launcher.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/public/test/test_utils.h	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	content/public/test/test_utils.cc	View	3 chunks	+10 lines, -21 lines	0 comments	Download

Total messages: 2 (0 generated)

Paweł Hajdan Jr.

Committed patchset #1 manually as r206451 (presubmit successful).

7 years, 6 months ago (2013-06-14 18:10:26 UTC) #1

Message was sent while issue was closed.

TBR