GTTF: Remove message loop hooks from TestLauncherDelegate

GTTF: Remove message loop hooks from TestLauncherDelegate

This is a step toward moving TestLauncher to base/test .

BUG=236893
R=sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203478

[sky, 2013-05-31 19:27:03]

https://codereview.chromium.org/15808008/diff/1/content/public/test/test_util...
File content/public/test/test_utils.cc (right):

https://codereview.chromium.org/15808008/diff/1/content/public/test/test_util...
content/public/test/test_utils.cc:88: for (size_t i = 0; i <
g_pre_run_message_loop_hooks.Get().size(); i++)
Should this use ObserverList for the case of the list being modified during
notification?

[Paweł Hajdan Jr., 2013-05-31 19:50:15]

https://codereview.chromium.org/15808008/diff/1/content/public/test/test_util...
File content/public/test/test_utils.cc (right):

https://codereview.chromium.org/15808008/diff/1/content/public/test/test_util...
content/public/test/test_utils.cc:88: for (size_t i = 0; i <
g_pre_run_message_loop_hooks.Get().size(); i++)
On 2013/05/31 19:27:03, sky wrote:
> Should this use ObserverList for the case of the list being modified during
> notification?

Good question.

ObserverList<RunMessageLoopHook>::AddObserver expects RunMessageLoopHook* though
(instead of const RunMessageLoopHook&). I think this creates tricky issues with
ownership, and at least these hooks won't be modified during iteration, so the
current implementation should be safe.

In fact, there are TODOs all over the place to remove it. :)

[sky, 2013-05-31 20:08:46]

Ok, LGTM

[Paweł Hajdan Jr., 2013-05-31 21:19:57]

Committed patchset #1 manually as r203478 (presubmit successful).