Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1452)

Unified Diff: chrome/browser/lifetime/keep_alive_options.h

Issue 1708343002: Add ScopedKeepAlive to c/b/lifetime (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/lifetime/keep_alive_options.h
diff --git a/chrome/browser/lifetime/keep_alive_options.h b/chrome/browser/lifetime/keep_alive_options.h
new file mode 100644
index 0000000000000000000000000000000000000000..8918912e6a0435505fa81e1841e834af42fe7b45
--- /dev/null
+++ b/chrome/browser/lifetime/keep_alive_options.h
@@ -0,0 +1,20 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_LIFETIME_KEEP_ALIVE_OPTIONS_H_
+#define CHROME_BROWSER_LIFETIME_KEEP_ALIVE_OPTIONS_H_
+
+struct KeepAliveOptions {
+ // Should be descriptive of what the KeepAlive's lifetime is tied to, to help
+ // with debugging.
+ const char* label;
sky 2016/02/22 21:26:05 Can you explain why a string is better than an enu
dgn 2016/02/23 12:58:06 The idea was that each call site would use a descr
+
+ // TODO(dgn)
+ // When registering a token, we should add indications of which kind of
+ // optimizations are allowed during the KeepAlive's lifetime. This will allow
+ // to have more info about the state of the browser to optimize the resource
+ // consumption.
+};
+
+#endif // CHROME_BROWSER_LIFETIME_KEEP_ALIVE_OPTIONS_H_
« no previous file with comments | « chrome/browser/guest_view/app_view/chrome_app_view_guest_delegate.cc ('k') | chrome/browser/lifetime/keep_alive_registry.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698