chrome/browser/lifetime/keep_alive_options.h - Issue 1708343002: Add ScopedKeepAlive to c/b/lifetime

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/lifetime/keep_alive_options.h

Issue 1708343002: Add ScopedKeepAlive to c/b/lifetime (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_LIFETIME_KEEP_ALIVE_OPTIONS_H_

	6 #define CHROME_BROWSER_LIFETIME_KEEP_ALIVE_OPTIONS_H_

	7

	8 struct KeepAliveOptions {

	9 // Should be descriptive of what the KeepAlive's lifetime is tied to, to help

	10 // with debugging.

	11 const char* label;
	sky 2016/02/22 21:26:05 Can you explain why a string is better than an enu Can you explain why a string is better than an enum here? An enum provides the context and is much easier in the call sites. dgn 2016/02/23 12:58:06 The idea was that each call site would use a descr Show quoted text On 2016/02/22 21:26:05, sky wrote: > Can you explain why a string is better than an enum here? An enum provides the > context and is much easier in the call sites. The idea was that each call site would use a descriptive string, that would give some information about the purpose of that KeepAlive. Those strings can be displayed for debug purposes, and for example could be shown in an about:// page. Having one enum per call site would require maintaining a centralized list, and have c/b/lifetime be aware of all the call sites, which I think would be strange. Also, we would still have to add the string mappings that go with that list for debugging. From the Release point of view, enums have their advantages. I don't feel strongly about that, I can change it if you want.
	12

	13 // TODO(dgn)

	14 // When registering a token, we should add indications of which kind of

	15 // optimizations are allowed during the KeepAlive's lifetime. This will allow

	16 // to have more info about the state of the browser to optimize the resource

	17 // consumption.

	18 };

	19

	20 #endif // CHROME_BROWSER_LIFETIME_KEEP_ALIVE_OPTIONS_H_

OLD	NEW