Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 1708293002: Revert of Add additive animation support for CSS properties perspective-origin and object-position (Closed)

Created:
4 years, 10 months ago by Theresa
Modified:
4 years, 10 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@_backgroundPositionAnimation
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add additive animation support for CSS properties perspective-origin and object-position (patchset #5 id:80001 of https://codereview.chromium.org/1690543002/ ) Reason for revert: The patchset this is dependent on is causing compilation to fail on Android arm64, x64, x86, and MIPS dbg builds, see https://code.google.com/p/chromium/issues/detail?id=587875 Sheriff is reverting. Original issue's description: > Add additive animation support for CSS properties perspective-origin and object-position > > This patch adds support for composite modes on perspective-origin and > object-position CSS animations via element.animate(). > > BUG=437696 > > Committed: https://crrev.com/d6c733e74a01031842f94995898f4fd885dd9a54 > Cr-Commit-Position: refs/heads/master@{#376156} TBR=dstockwell@chromium.org,ericwilligers@chromium.org,alancutter@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=437696 Committed: https://crrev.com/b3504c8e225a3be2457da83a77a3554365d80bc6 Cr-Commit-Position: refs/heads/master@{#376190}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -242 lines) Patch
D third_party/WebKit/LayoutTests/animations/composition/object-position-composition.html View 1 chunk +0 lines, -64 lines 0 comments Download
D third_party/WebKit/LayoutTests/animations/composition/perspective-origin-composition.html View 1 chunk +0 lines, -71 lines 0 comments Download
M third_party/WebKit/LayoutTests/animations/interpolation/object-position-interpolation.html View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSPositionAxisListInterpolationType.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/animation/CSSPositionAxisListInterpolationType.cpp View 1 chunk +8 lines, -25 lines 0 comments Download
D third_party/WebKit/Source/core/animation/CSSPositionInterpolationType.h View 1 chunk +0 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/core/animation/LengthListPropertyFunctions.cpp View 3 chunks +2 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/animation/PropertyInterpolationTypesMapping.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/animation/StringKeyframe.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Theresa
Created Revert of Add additive animation support for CSS properties perspective-origin and object-position
4 years, 10 months ago (2016-02-18 17:18:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1708293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1708293002/1
4 years, 10 months ago (2016-02-18 17:20:25 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-18 17:22:38 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 17:24:02 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b3504c8e225a3be2457da83a77a3554365d80bc6
Cr-Commit-Position: refs/heads/master@{#376190}

Powered by Google App Engine
This is Rietveld 408576698