Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1001)

Unified Diff: third_party/WebKit/Source/core/animation/LengthListPropertyFunctions.cpp

Issue 1708293002: Revert of Add additive animation support for CSS properties perspective-origin and object-position (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_backgroundPositionAnimation
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/LengthListPropertyFunctions.cpp
diff --git a/third_party/WebKit/Source/core/animation/LengthListPropertyFunctions.cpp b/third_party/WebKit/Source/core/animation/LengthListPropertyFunctions.cpp
index 28fc54865a575bfbacbf85944dfa558a2387d185..62680c3450d5a13992161e2c35fd823e47a464e1 100644
--- a/third_party/WebKit/Source/core/animation/LengthListPropertyFunctions.cpp
+++ b/third_party/WebKit/Source/core/animation/LengthListPropertyFunctions.cpp
@@ -76,8 +76,6 @@
switch (property) {
case CSSPropertyBackgroundPositionX:
case CSSPropertyBackgroundPositionY:
- case CSSPropertyObjectPosition:
- case CSSPropertyPerspectiveOrigin:
case CSSPropertyWebkitMaskPositionX:
case CSSPropertyWebkitMaskPositionY:
return ValueRangeAll;
@@ -100,21 +98,10 @@
{
Vector<Length> result;
- switch (property) {
- case CSSPropertyStrokeDasharray:
+ if (property == CSSPropertyStrokeDasharray) {
if (style.strokeDashArray())
result.appendVector(style.strokeDashArray()->vector());
return result;
- case CSSPropertyObjectPosition:
- result.append(style.objectPosition().x());
- result.append(style.objectPosition().y());
- return result;
- case CSSPropertyPerspectiveOrigin:
- result.append(style.perspectiveOrigin().x());
- result.append(style.perspectiveOrigin().y());
- return result;
- default:
- break;
}
const FillLayer* fillLayer = getFillLayer(property, style);
@@ -128,18 +115,9 @@
void LengthListPropertyFunctions::setLengthList(CSSPropertyID property, ComputedStyle& style, Vector<Length>&& lengthList)
{
- switch (property) {
- case CSSPropertyStrokeDasharray:
+ if (property == CSSPropertyStrokeDasharray) {
style.setStrokeDashArray(lengthList.isEmpty() ? nullptr : RefVector<Length>::create(std::move(lengthList)));
return;
- case CSSPropertyObjectPosition:
- style.setObjectPosition(LengthPoint(lengthList[0], lengthList[1]));
- return;
- case CSSPropertyPerspectiveOrigin:
- style.setPerspectiveOrigin(LengthPoint(lengthList[0], lengthList[1]));
- return;
- default:
- break;
}
FillLayer* fillLayer = accessFillLayer(property, style);

Powered by Google App Engine
This is Rietveld 408576698