media/video/gpu_memory_buffer_video_frame_pool.cc - Issue 1708263002: gpu: Expose internal format R8 instead of RED.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/video/gpu_memory_buffer_video_frame_pool.cc

Issue 1708263002: gpu: Expose internal format R8 instead of RED. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert to 'Address reveman's comments'. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/video/gpu_memory_buffer_video_frame_pool.cc

diff --git a/media/video/gpu_memory_buffer_video_frame_pool.cc b/media/video/gpu_memory_buffer_video_frame_pool.cc

index e7ffd99332be2d29bb1251968d80001562fbfc2f..6663a945fb0a6b4e42808f4e4e57c65e5065348f 100644

--- a/media/video/gpu_memory_buffer_video_frame_pool.cc

+++ b/media/video/gpu_memory_buffer_video_frame_pool.cc

@@ -199,7 +199,7 @@ unsigned ImageInternalFormat(VideoPixelFormat format, size_t plane) {

switch (format) {

case PIXEL_FORMAT_I420:

DCHECK_LE(plane, 2u);

- return GL_RED_EXT;

+ return GL_R8_EXT;

case PIXEL_FORMAT_NV12:

DCHECK_LE(plane, 1u);

return GL_RGB_YCBCR_420V_CHROMIUM;