gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc - Issue 1708263002: gpu: Expose internal format R8 instead of RED.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc

Issue 1708263002: gpu: Expose internal format R8 instead of RED. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert to 'Address reveman's comments'. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc

diff --git a/gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc b/gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc

index 5f1e1e0a1194bf01bd69fd038a67e440eac1a43b..a434df1797acfeb403ed4912a55e2eece1f4f4aa 100644

--- a/gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc

+++ b/gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc

@@ -128,7 +128,7 @@ void SetRow(gfx::BufferFormat format,

GLenum InternalFormat(gfx::BufferFormat format) {

switch (format) {

case gfx::BufferFormat::R_8:

- return GL_RED;

+ return GL_R8;

case gfx::BufferFormat::RGBA_4444:

case gfx::BufferFormat::RGBA_8888:

return GL_RGBA;