Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: gpu/command_buffer/service/image_factory.cc

Issue 1708263002: gpu: Expose internal format R8 instead of RED. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address reveman's comments. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« gpu/command_buffer/service/gles2_cmd_decoder.cc ('K') | « gpu/command_buffer/service/gles2_cmd_decoder.cc ('k') | gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc » ('j') | ui/gl/gl_image_io_surface.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/image_factory.cc
diff --git a/gpu/command_buffer/service/image_factory.cc b/gpu/command_buffer/service/image_factory.cc
index a96da9a46a6535746bd9d5fe4b3cf62734824e27..b60d644edf2e1f2ee265ecc7a8ff2cfb4f777b71 100644
--- a/gpu/command_buffer/service/image_factory.cc
+++ b/gpu/command_buffer/service/image_factory.cc
@@ -19,7 +19,7 @@ ImageFactory::~ImageFactory() {
gfx::BufferFormat ImageFactory::DefaultBufferFormatForImageFormat(
unsigned internalformat) {
switch (internalformat) {
- case GL_RED:
+ case GL_R8:
Zhenyao Mo 2016/02/22 22:53:08 Please also keep GL_RED
return gfx::BufferFormat::R_8;
case GL_RGB:
return gfx::BufferFormat::BGRX_8888;
« gpu/command_buffer/service/gles2_cmd_decoder.cc ('K') | « gpu/command_buffer/service/gles2_cmd_decoder.cc ('k') | gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc » ('j') | ui/gl/gl_image_io_surface.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698