gpu/command_buffer/service/gles2_cmd_decoder.cc - Issue 1708263002: gpu: Expose internal format R8 instead of RED.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder.cc

Issue 1708263002: gpu: Expose internal format R8 instead of RED. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address reveman's comments. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gpu/command_buffer/service/gles2_cmd_decoder.cc

diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc

index 146791ccd59551da9e795c7aec485cd95f1a825b..6165f0bfc01810488d24d95cdefd13dc05ad1f66 100644

--- a/gpu/command_buffer/service/gles2_cmd_decoder.cc

+++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc

@@ -13158,7 +13158,7 @@ bool GLES2DecoderImpl::ValidateCopyTextureCHROMIUMInternalFormats(

dest_internal_format == GL_RGBA ||

dest_internal_format == GL_BGRA_EXT;

bool valid_source_format =

- source_internal_format == GL_RED || source_internal_format == GL_ALPHA ||

+ source_internal_format == GL_R8 || source_internal_format == GL_ALPHA ||

Zhenyao Mo 2016/02/22 22:53:08 Please also keep GL_RED

Daniele Castagna 2016/02/22 23:16:33 Done.

source_internal_format == GL_RGB || source_internal_format == GL_RGBA ||

source_internal_format == GL_LUMINANCE ||

source_internal_format == GL_LUMINANCE_ALPHA ||