Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Issue 1708173002: Remove support of the -webkit-text value from {-webkit-,}background-clip (Closed)

Created:
4 years, 10 months ago by fs
Modified:
4 years, 10 months ago
Reviewers:
Timothy Loh
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove support of the -webkit-text value from {-webkit-,}background-clip Usage is essentially/rounding to zero [1]. [1] https://www.chromestatus.com/metrics/feature/timeline/popularity/941 BUG=586485 Committed: https://crrev.com/76c9350fe5f8fd86517fd0707c10b76508e71119 Cr-Commit-Position: refs/heads/master@{#376421}

Patch Set 1 #

Patch Set 2 : Update tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -21 lines) Patch
M third_party/WebKit/LayoutTests/fast/css/background-clip-text-expected.txt View 1 1 chunk +1 line, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/script-tests/background-clip-text.js View 1 3 chunks +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp View 2 chunks +3 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
fs
4 years, 10 months ago (2016-02-18 17:50:43 UTC) #2
Timothy Loh
On 2016/02/18 17:50:43, fs wrote: lgtm
4 years, 10 months ago (2016-02-18 22:45:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1708173002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1708173002/20001
4 years, 10 months ago (2016-02-19 08:47:17 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-19 08:54:12 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 08:55:11 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/76c9350fe5f8fd86517fd0707c10b76508e71119
Cr-Commit-Position: refs/heads/master@{#376421}

Powered by Google App Engine
This is Rietveld 408576698