third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp - Issue 1708173002: Remove support of the -webkit-text value from {-webkit-,}background-clip

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp

Issue 1708173002: Remove support of the -webkit-text value from {-webkit-,}background-clip (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update tests Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h ('k') | third_party/WebKit/Source/core/frame/UseCounter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp

diff --git a/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp b/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp

index f9359994090209a2ccb411fdeee4995e4d15494e..2155956773a108cbe78f45329a7654badd409472 100644

--- a/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp

+++ b/third_party/WebKit/Source/core/css/parser/LegacyCSSPropertyParser.cpp

@@ -456,7 +456,7 @@ void CSSPropertyParser::addFillValue(RefPtrWillBeRawPtr<CSSValue>& lval, PassRef

static bool parseBackgroundClip(CSSParserValue* parserValue, RefPtrWillBeRawPtr<CSSValue>& cssValue)

{

if (parserValue->id == CSSValueBorderBox || parserValue->id == CSSValuePaddingBox

- || parserValue->id == CSSValueContentBox || parserValue->id == CSSValueWebkitText) {

+ || parserValue->id == CSSValueContentBox) {

cssValue = cssValuePool().createIdentifierValue(parserValue->id);

return true;

}

@@ -1149,19 +1149,14 @@ bool CSSPropertyParser::parseFillProperty(CSSPropertyID propId, CSSPropertyID& p

if (val->id == CSSValueBorder || val->id == CSSValuePadding || val->id == CSSValueContent

|| val->id == CSSValueBorderBox || val->id == CSSValuePaddingBox || val->id == CSSValueContentBox

|| ((propId == CSSPropertyWebkitBackgroundClip || propId == CSSPropertyWebkitMaskClip)

- && (val->id == CSSValueText || val->id == CSSValueWebkitText))) {

- if (val->id == CSSValueWebkitText && m_context.useCounter())

- m_context.useCounter()->count(UseCounter::WebkitTextInClipProperty);

+ && val->id == CSSValueText)) {

currValue = cssValuePool().createIdentifierValue(val->id);

m_valueList->next();

}

break;

case CSSPropertyBackgroundClip:

- if (parseBackgroundClip(val, currValue)) {

- if (val->id == CSSValueWebkitText && m_context.useCounter())

- m_context.useCounter()->count(UseCounter::WebkitTextInClipProperty);

+ if (parseBackgroundClip(val, currValue))

m_valueList->next();

- }

break;

case CSSPropertyBackgroundOrigin:

if (val->id == CSSValueBorderBox || val->id == CSSValuePaddingBox || val->id == CSSValueContentBox) {