Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1707923002: Expand all paths to be based off pdfium/ directory (Closed)

Created:
4 years, 10 months ago by dsinclair
Modified:
4 years, 10 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Expand all paths to be based off pdfium/ directory This CL runs a script over the source and updates the include files to be a full path from the pdfium/ directory. BUG=pdfium:65 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/efbc1912f10f5a53e7df3a24ebfd6b78412f0bba

Patch Set 1 #

Total comments: 98

Patch Set 2 : Sort headers #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+422 lines, -427 lines) Patch
M core/include/fpdfdoc/fpdf_ap.h View 1 chunk +1 line, -1 line 0 comments Download
M core/include/fxcodec/fx_codec.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M core/include/fxcrt/fx_arb.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/include/fxcrt/fx_basic.h View 1 chunk +4 lines, -4 lines 0 comments Download
M core/include/fxcrt/fx_bidi.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/include/fxcrt/fx_coordinates.h View 1 chunk +1 line, -1 line 0 comments Download
M core/include/fxcrt/fx_memory.h View 1 chunk +1 line, -1 line 0 comments Download
M core/include/fxcrt/fx_safe_types.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/include/fxcrt/fx_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M core/include/fxcrt/fx_string.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/include/fxcrt/fx_ucd.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/CNS1/Adobe-CNS1-UCS2_5.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/CNS1/B5pc-H_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/CNS1/B5pc-V_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/CNS1/CNS-EUC-H_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/CNS1/CNS-EUC-V_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/CNS1/ETen-B5-H_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/CNS1/ETen-B5-V_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/CNS1/ETenms-B5-H_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/CNS1/ETenms-B5-V_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/CNS1/HKscs-B5-H_5.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/CNS1/HKscs-B5-V_5.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/CNS1/UniCNS-UCS2-H_3.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/CNS1/UniCNS-UCS2-V_3.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/CNS1/UniCNS-UTF16-H_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/CNS1/cmaps_cns1.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/GB1/Adobe-GB1-UCS2_5.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/GB1/GB-EUC-H_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/GB1/GB-EUC-V_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/GB1/GBK-EUC-H_2.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/GB1/GBK-EUC-V_2.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/GB1/GBK2K-H_5.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/GB1/GBK2K-V_5.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/GB1/GBKp-EUC-H_2.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/GB1/GBKp-EUC-V_2.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/GB1/GBpc-EUC-H_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/GB1/GBpc-EUC-V_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/GB1/UniGB-UCS2-H_4.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/GB1/UniGB-UCS2-V_4.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/GB1/cmaps_gb1.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/Japan1/83pv-RKSJ-H_1.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/Japan1/90ms-RKSJ-H_2.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/Japan1/90ms-RKSJ-V_2.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/Japan1/90msp-RKSJ-H_2.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/Japan1/90msp-RKSJ-V_2.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/Japan1/90pv-RKSJ-H_1.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/Japan1/Add-RKSJ-H_1.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/Japan1/Add-RKSJ-V_1.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/Japan1/Adobe-Japan1-UCS2_4.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/Japan1/EUC-H_1.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/Japan1/EUC-V_1.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/Japan1/Ext-RKSJ-H_2.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/Japan1/Ext-RKSJ-V_2.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/Japan1/H_1.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/Japan1/UniJIS-UCS2-HW-H_4.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/Japan1/UniJIS-UCS2-HW-V_4.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/Japan1/UniJIS-UCS2-H_4.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/Japan1/UniJIS-UCS2-V_4.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/Japan1/V_1.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/Japan1/cmaps_japan1.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/Korea1/Adobe-Korea1-UCS2_2.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/Korea1/KSC-EUC-H_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/Korea1/KSC-EUC-V_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/Korea1/KSCms-UHC-HW-H_1.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/Korea1/KSCms-UHC-HW-V_1.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/Korea1/KSCms-UHC-H_1.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/Korea1/KSCms-UHC-V_1.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/Korea1/KSCpc-EUC-H_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/Korea1/UniKS-UCS2-H_1.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/Korea1/UniKS-UCS2-V_1.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/Korea1/UniKS-UTF16-H_0.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/Korea1/cmaps_korea1.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_cmaps/fpdf_cmaps.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font_cid.cpp View 1 3 chunks +2 lines, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font_cid_unittest.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/fpdf_font_unittest.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_font/ttgsubtable.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_doc.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_graph_state.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_image.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_parser_old_unittest.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_path.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_page/fpdf_page_pattern.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_cache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_image.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_pattern.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_text.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfdoc/doc_ap.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fpdfdoc/doc_form.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfdoc/doc_formfield.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfdoc/doc_tagged.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfdoc/doc_utils.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfdoc/doc_vt.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdfdoc/doc_vtmodule.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdftext/unicodenormalization.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fpdftext/unicodenormalizationdata.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/codec/fx_codec.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/codec/fx_codec_bmp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/codec/fx_codec_fax.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/codec/fx_codec_flate.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/codec/fx_codec_gif.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/codec/fx_codec_icc.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/codec/fx_codec_jbig.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/codec/fx_codec_jpeg.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/codec/fx_codec_jpx_opj.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/codec/fx_codec_jpx_unittest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/codec/fx_codec_png.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/codec/fx_codec_progress.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/codec/fx_codec_tiff.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_ArithDecoder.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_ArithIntDecoder.h View 1 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_ArithIntDecoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_BitStream.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_Context.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_GrdProc.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_GrrdProc.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_GsidProc.cpp View 1 1 chunk +5 lines, -5 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_HtrdProc.h View 1 1 chunk +1 line, -2 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_HtrdProc.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_HuffmanDecoder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_HuffmanDecoder.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_Image.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_Image.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_PatternDict.h View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_PatternDict.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_PddProc.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_SddProc.h View 1 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_Segment.h View 1 chunk +4 lines, -4 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_Segment.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_SymbolDict.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_SymbolDict.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_TrdProc.h View 1 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/jbig2/JBig2_TrdProc.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M core/src/fxcodec/lbmp/fx_bmp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcodec/lgif/fx_gif.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fx_arabic.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fx_basic_list.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fx_basic_maps.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fx_basic_plex.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fx_extension.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fx_xml_composer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fx_xml_parser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fxcrt_platforms.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fxcrt_platforms.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fxcrt_posix.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fxcrt_posix.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fxcrt_windows.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fxcrt_windows.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/android/fpf_skiafont.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M core/src/fxge/android/fpf_skiafontmgr.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxge/android/fpf_skiamodule.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M core/src/fxge/android/fx_android_font.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/android/fx_android_imp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/android/fx_fpf.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/apple/fx_apple_platform.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/apple/fx_mac_imp.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/apple/fx_quartz_device.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/dib/fx_dib_composite.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/dib/fx_dib_engine.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/dib/fx_dib_main.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/dib/fx_dib_transform.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/fontdata/chromefontdata/FoxitDingbats.c View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/fontdata/chromefontdata/FoxitFixed.c View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/fontdata/chromefontdata/FoxitFixedBold.c View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/fontdata/chromefontdata/FoxitFixedBoldItalic.c View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/fontdata/chromefontdata/FoxitFixedItalic.c View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/fontdata/chromefontdata/FoxitSans.c View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/fontdata/chromefontdata/FoxitSansBold.c View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/fontdata/chromefontdata/FoxitSansBoldItalic.c View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/fontdata/chromefontdata/FoxitSansItalic.c View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/fontdata/chromefontdata/FoxitSansMM.c View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/fontdata/chromefontdata/FoxitSerif.c View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/fontdata/chromefontdata/FoxitSerifBold.c View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/fontdata/chromefontdata/FoxitSerifBoldItalic.c View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/fontdata/chromefontdata/FoxitSerifItalic.c View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/fontdata/chromefontdata/FoxitSerifMM.c View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/fontdata/chromefontdata/FoxitSymbol.c View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/skia/fx_skia_blitter_new.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/skia/fx_skia_device.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M core/src/fxge/win32/fx_win32_dib.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/win32/fx_win32_dwrite.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/win32/fx_win32_gdipext.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/win32/fx_win32_print.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/win32/win32_int.h View 1 2 chunks +1 line, -1 line 0 comments Download
M fpdfsdk/include/formfiller/FFL_CheckBox.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/formfiller/FFL_ComboBox.h View 1 chunk +1 line, -1 line 1 comment Download
M fpdfsdk/include/formfiller/FFL_ListBox.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/formfiller/FFL_PushButton.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/formfiller/FFL_RadioButton.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/formfiller/FFL_TextField.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/fsdk_actionhandler.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/fsdk_mgr.h View 1 chunk +7 lines, -7 lines 0 comments Download
M fpdfsdk/include/fsdk_rendercontext.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/fxedit/fxet_list.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Button.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Caret.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_ComboBox.h View 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_EditCtrl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Icon.h View 1 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_IconList.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Label.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_ListBox.h View 1 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_ListCtrl.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Note.h View 1 chunk +5 lines, -5 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_ScrollBar.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Signature.h View 1 chunk +2 lines, -2 lines 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_SpecialButton.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/include/pdfwindow/PWL_Utils.h View 1 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/fpdfview_c_api_test.c View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/Consts.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/Consts.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/javascript/Document.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/Document.cpp View 1 1 chunk +12 lines, -12 lines 0 comments Download
M fpdfsdk/src/javascript/Field.h View 1 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/Field.cpp View 1 1 chunk +11 lines, -11 lines 0 comments Download
M fpdfsdk/src/javascript/Icon.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/Icon.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Context.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Define.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/javascript/JS_EventHandler.cpp View 1 1 chunk +9 lines, -9 lines 0 comments Download
M fpdfsdk/src/javascript/JS_GlobalData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/JS_Object.h View 1 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/JS_Object.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.h View 1 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.cpp View 1 1 chunk +20 lines, -20 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Value.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/javascript/PublicMethods.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/PublicMethods.cpp View 1 1 chunk +11 lines, -11 lines 0 comments Download
M fpdfsdk/src/javascript/app.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/app.cpp View 1 1 chunk +9 lines, -9 lines 0 comments Download
M fpdfsdk/src/javascript/color.h View 1 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/color.cpp View 1 1 chunk +8 lines, -8 lines 0 comments Download
M fpdfsdk/src/javascript/console.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/console.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M fpdfsdk/src/javascript/event.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/event.cpp View 1 1 chunk +8 lines, -8 lines 0 comments Download
M fpdfsdk/src/javascript/global.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/global.cpp View 1 1 chunk +9 lines, -9 lines 0 comments Download
M fpdfsdk/src/javascript/report.h View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/report.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/javascript/resource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M fpdfsdk/src/javascript/util.h View 1 chunk +1 line, -1 line 0 comments Download
M samples/image_diff.cc View 1 chunk +1 line, -1 line 0 comments Download
M samples/image_diff_png.cc View 1 chunk +1 line, -1 line 0 comments Download
M samples/pdfium_test.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M testing/embedder_test_mock_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M testing/embedder_test_timer_handling_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M testing/fx_string_testhelpers.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Tom Sepez
All in all, it's an improvement. LGTM https://codereview.chromium.org/1707923002/diff/1/core/include/fxcodec/fx_codec.h File core/include/fxcodec/fx_codec.h (right): https://codereview.chromium.org/1707923002/diff/1/core/include/fxcodec/fx_codec.h#newcode17 core/include/fxcodec/fx_codec.h:17: #include "core/include/fxcodec/fx_codec_def.h" ...
4 years, 10 months ago (2016-02-17 21:32:28 UTC) #2
dsinclair
https://codereview.chromium.org/1707923002/diff/1/core/include/fxcodec/fx_codec.h File core/include/fxcodec/fx_codec.h (right): https://codereview.chromium.org/1707923002/diff/1/core/include/fxcodec/fx_codec.h#newcode17 core/include/fxcodec/fx_codec.h:17: #include "core/include/fxcodec/fx_codec_def.h" On 2016/02/17 21:32:26, Tom Sepez wrote: > ...
4 years, 10 months ago (2016-02-17 21:54:02 UTC) #3
dsinclair
Committed patchset #2 (id:20001) manually as efbc1912f10f5a53e7df3a24ebfd6b78412f0bba (presubmit successful).
4 years, 10 months ago (2016-02-17 21:54:50 UTC) #5
Lei Zhang
4 years, 10 months ago (2016-02-18 01:17:26 UTC) #7
Message was sent while issue was closed. 
Wee! We still have to do xfa/ right?

https://codereview.chromium.org/1707923002/diff/20001/fpdfsdk/include/formfil...
File fpdfsdk/include/formfiller/FFL_ComboBox.h (right):

https://codereview.chromium.org/1707923002/diff/20001/fpdfsdk/include/formfil...
fpdfsdk/include/formfiller/FFL_ComboBox.h:10: #include
"fpdfsdk/include/formfiller/FFL_FormFiller.h"
not all sorted? *shrug*

Powered by Google App Engine
This is Rietveld 408576698