Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Issue 1707453002: Reland of Parse USB interface association descriptors. (Closed)

Created:
4 years, 10 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Parse USB interface association descriptors. (patchset #1 id:1 of https://codereview.chromium.org/1697863003/ ) Reason for revert: Relanding this with a new implementation and fixed the test bug that led this issue to not be caught in the first place. Original issue's description: > Revert of Parse USB interface association descriptors. (patchset #3 id:100001 of https://codereview.chromium.org/1568673002/ ) > > Reason for revert: > http://crbug.com/586824 > > Makes Chrome hang when using USB devices. > > Original issue's description: > > Parse USB interface association descriptors. > > > > USB interface association descriptors are used to combine multiple > > interfaces into a single functional group. This patch adds support for > > parsing them out of the |extra_data| field left by libusb's parsing of > > configuration, interface and endpoint descriptors. The resulting > > association is then represented by setting the |first_interface| field > > of each interface in a function to the |interface_number| of the first > > interface in the function. > > > > WebUSB will use these associations to set permissions for an entire > > function with a single descriptor. BUG=492204, 586824 Committed: https://crrev.com/6a2b2b5dafce11505958fbb945088347540fb9f7 Cr-Commit-Position: refs/heads/master@{#383543}

Patch Set 1 #

Patch Set 2 : Fixed issues for reland #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -1 line) Patch
M device/usb/usb_descriptors.h View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M device/usb/usb_descriptors.cc View 1 2 4 chunks +85 lines, -1 line 0 comments Download
M device/usb/usb_descriptors_unittest.cc View 1 1 chunk +94 lines, -0 lines 0 comments Download
M device/usb/usb_device_impl.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Reilly Grant (use Gerrit)
Created Reland of Parse USB interface association descriptors.
4 years, 10 months ago (2016-02-16 18:35:29 UTC) #1
Reilly Grant (use Gerrit)
Did I ever mail this out? I guess not? Please take a look.
4 years, 10 months ago (2016-02-24 22:43:46 UTC) #4
Ken Rockot(use gerrit already)
sorry. D: lgtm
4 years, 9 months ago (2016-03-25 19:25:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1707453002/150001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1707453002/150001
4 years, 8 months ago (2016-03-28 18:30:44 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:150001)
4 years, 8 months ago (2016-03-28 19:45:26 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-03-28 19:47:02 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6a2b2b5dafce11505958fbb945088347540fb9f7
Cr-Commit-Position: refs/heads/master@{#383543}

Powered by Google App Engine
This is Rietveld 408576698