Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issue 1697863003: Revert of Parse USB interface association descriptors. (Closed)

Created:
4 years, 10 months ago by gab
Modified:
4 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Parse USB interface association descriptors. (patchset #3 id:100001 of https://codereview.chromium.org/1568673002/ ) Reason for revert: http://crbug.com/586824 Makes Chrome hang when using USB devices. Original issue's description: > Parse USB interface association descriptors. > > USB interface association descriptors are used to combine multiple > interfaces into a single functional group. This patch adds support for > parsing them out of the |extra_data| field left by libusb's parsing of > configuration, interface and endpoint descriptors. The resulting > association is then represented by setting the |first_interface| field > of each interface in a function to the |interface_number| of the first > interface in the function. > > WebUSB will use these associations to set permissions for an entire > function with a single descriptor. > TBR=rockot@chromium.org,pfeldman@chromium.org,stevenjb@chromium.org,reillyg@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=492204, 586824 Committed: https://crrev.com/894ae258c08e0b531cefcf6167d9d189d44d26e0 Cr-Commit-Position: refs/heads/master@{#375392}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -163 lines) Patch
M device/usb/usb_descriptors.h View 2 chunks +0 lines, -6 lines 0 comments Download
M device/usb/usb_descriptors.cc View 4 chunks +1 line, -80 lines 0 comments Download
M device/usb/usb_descriptors_unittest.cc View 1 chunk +0 lines, -75 lines 0 comments Download
M device/usb/usb_device_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
gab
Created Revert of Parse USB interface association descriptors.
4 years, 10 months ago (2016-02-14 21:03:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697863003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697863003/1
4 years, 10 months ago (2016-02-14 21:04:16 UTC) #5
Reilly Grant (use Gerrit)
lgtm
4 years, 10 months ago (2016-02-14 21:20:54 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-14 22:09:06 UTC) #8
Reilly Grant (use Gerrit)
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1707453002/ by reillyg@chromium.org. ...
4 years, 10 months ago (2016-02-16 18:35:28 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:48:25 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/894ae258c08e0b531cefcf6167d9d189d44d26e0
Cr-Commit-Position: refs/heads/master@{#375392}

Powered by Google App Engine
This is Rietveld 408576698