Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1707433002: IFWL_App::Create() always passed adapter, "fuel" adapter unused (Closed)

Created:
4 years, 10 months ago by Tom Sepez
Modified:
4 years, 10 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

IFWL_App::Create() always passed adapter, "fuel" adapter unused R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/5f554133283d03b6b30bcecfcdc689cccf3799ec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -39 lines) Patch
M xfa/include/fwl/adapter/fwl_adapternative.h View 2 chunks +4 lines, -5 lines 0 comments Download
M xfa/src/fwl/src/core/fwl_appimp.cpp View 2 chunks +11 lines, -24 lines 0 comments Download
M xfa/src/fwl/src/core/include/fwl_appimp.h View 2 chunks +7 lines, -6 lines 0 comments Download
M xfa/src/fxfa/src/app/xfa_fwladapter.cpp View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Tom Sepez
Lei, pls. review.
4 years, 10 months ago (2016-02-16 17:24:49 UTC) #2
Lei Zhang
lgtm
4 years, 10 months ago (2016-02-16 19:32:12 UTC) #4
Tom Sepez
4 years, 10 months ago (2016-02-16 19:34:41 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
5f554133283d03b6b30bcecfcdc689cccf3799ec (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698