IFWL_App::Create() always passed adapter, "fuel" adapter unused

xfa/src/fwl/src/core/fwl_appimp.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/src/foxitlib.h"
 #include "xfa/src/fwl/src/core/include/fwl_targetimp.h"
 #include "xfa/src/fwl/src/core/include/fwl_threadimp.h"
 #include "xfa/src/fwl/src/core/include/fwl_noteimp.h"
@@ skipping 21 matching lines @@
   return static_cast<CFWL_AppImp*>(GetImpl())->GetThemeProvider();
 }
 FWL_ERR IFWL_App::SetThemeProvider(IFWL_ThemeProvider* pThemeProvider) {
   return static_cast<CFWL_AppImp*>(GetImpl())->SetThemeProvider(pThemeProvider);
 }
 FWL_ERR IFWL_App::Exit(int32_t iExitCode) {
   return static_cast<CFWL_AppImp*>(GetImpl())->Exit(iExitCode);
 }
 
 CFWL_AppImp::CFWL_AppImp(IFWL_App* pIface, IFWL_AdapterNative* pAdapter)
-    : CFWL_NoteThreadImp(pIface), m_pWidgetMgr(NULL), m_pThemeProvider(NULL) {
-  if (!pAdapter) {
-    pAdapter = FWL_CreateFuelAdapterNative();
-    m_bFuelAdapter = TRUE;
-  } else {
-    m_bFuelAdapter = FALSE;
-  }
-  m_pAdapterNative = pAdapter;
-}
+    : CFWL_NoteThreadImp(pIface),
+      m_pAdapterNative(pAdapter),
+      m_pThemeProvider(nullptr) {}
+
 CFWL_AppImp::~CFWL_AppImp() {
   CFWL_ToolTipContainer::DeleteInstance();
-  if (m_bFuelAdapter) {
-    FWL_ReleaseFuelAdapterNative(m_pAdapterNative);
-    m_pAdapterNative = NULL;
-  }
-  if (m_pWidgetMgr) {
-    delete m_pWidgetMgr;
-    m_pWidgetMgr = NULL;
-  }
 }
+
 FWL_ERR CFWL_AppImp::Initialize() {
   if (!m_pWidgetMgr) {
-    m_pWidgetMgr = new CFWL_WidgetMgr(m_pAdapterNative);
+    m_pWidgetMgr.reset(new CFWL_WidgetMgr(m_pAdapterNative));
   }
   return FWL_ERR_Succeeded;
 }
 FWL_ERR CFWL_AppImp::Finalize() {
-  delete m_pWidgetMgr;
-  m_pWidgetMgr = NULL;
+  m_pWidgetMgr.reset();
   return FWL_ERR_Succeeded;
 }
-IFWL_AdapterNative* CFWL_AppImp::GetAdapterNative() {
+IFWL_AdapterNative* CFWL_AppImp::GetAdapterNative() const {
   return m_pAdapterNative;
 }
 IFWL_AdapterWidgetMgr* FWL_GetAdapterWidgetMgr() {
   return static_cast<CFWL_WidgetMgr*>(FWL_GetWidgetMgr())
       ->GetAdapterWidgetMgr();
 }
-IFWL_WidgetMgr* CFWL_AppImp::GetWidgetMgr() {
-  return m_pWidgetMgr;
+IFWL_WidgetMgr* CFWL_AppImp::GetWidgetMgr() const {
+  return m_pWidgetMgr.get();
 }
 FWL_ERR CFWL_AppImp::SetThemeProvider(IFWL_ThemeProvider* pThemeProvider) {
   m_pThemeProvider = pThemeProvider;
   return FWL_ERR_Succeeded;
 }
 FWL_ERR CFWL_AppImp::Exit(int32_t iExitCode) {
   while (m_pNoteDriver->PopNoteLoop())
     ;
   return m_pWidgetMgr->GetAdapterWidgetMgr()->Exit(0);
 }
-IFWL_ThemeProvider* CFWL_AppImp::GetThemeProvider() {
+IFWL_ThemeProvider* CFWL_AppImp::GetThemeProvider() const {
   return m_pThemeProvider;
 }
 IFWL_AdapterNative* FWL_GetAdapterNative() {
   IFWL_App* pApp = FWL_GetApp();
   if (!pApp)
     return NULL;
   return pApp->GetAdapterNative();
 }
 IFWL_ThemeProvider* FWL_GetThemeProvider() {
   return NULL;
@@ skipping 11 matching lines @@
   IFWL_NoteThread* pNoteTread = pWidget->GetOwnerThread();
   if (!pNoteTread)
     return FWL_ERR_Succeeded;
   CFWL_NoteDriver* pNoteDriver =
       static_cast<CFWL_NoteDriver*>(pNoteTread->GetNoteDriver());
   if (!pNoteTread)
     return FWL_ERR_Succeeded;
   pNoteDriver->NotifyFullScreenMode(pWidget, bFullScreen);
   return FWL_GetAdapterWidgetMgr()->SetFullScreen(pWidget, bFullScreen);
 }