Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issue 170743009: Revert of Adding the chrome://suggestions test page. (Closed)

Created:
6 years, 10 months ago by Lei Zhang
Modified:
6 years, 10 months ago
Reviewers:
Mathieu, beaudoin, sky, Jered, huangs
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Visibility:
Public.

Description

Revert of Adding the chrome://suggestions test page. (https://codereview.chromium.org/163953005/) Reason for revert: SuggestionsCombinerTest.TestSuite and SuggestionsCombinerTest.SourcesAreNotDoneFetching crashing on Linux clang, as well as some Mac bots. Original issue's description: > The test page requires proper Canary flag to be set. See SuggestionsService::IsEnabled(). > > Details: > - Changing the interface of SuggestionsService, so results are returned via callbacks. Also updating tests. > - To support calls to SuggestionsService::FetchSuggestionsData() while data fetch takes place, we queue callbacks, and serve all data when data fetch completes. > - Adding SuggestionsService::Shutdown() to handle mid-flight shutdown. > - Making chrome://suggestions unavailable for incognito mode. > > BUG=None > Test=SuggestionsServiceTest > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251935 TBR=mathp@chromium.org,beaudoin@chromium.org,jered@chromium.org,sky@chromium.org,huangs@chromium.org NOTREECHECKS=true NOTRY=true BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251950

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -285 lines) Patch
M chrome/browser/search/instant_service.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/search/suggestions/suggestions_service.h View 2 chunks +14 lines, -21 lines 0 comments Download
M chrome/browser/search/suggestions/suggestions_service.cc View 5 chunks +6 lines, -43 lines 0 comments Download
M chrome/browser/search/suggestions/suggestions_service_unittest.cc View 4 chunks +11 lines, -31 lines 0 comments Download
D chrome/browser/search/suggestions/suggestions_source.h View 1 chunk +0 lines, -59 lines 0 comments Download
D chrome/browser/search/suggestions/suggestions_source.cc View 1 chunk +0 lines, -110 lines 0 comments Download
M chrome/browser/ui/browser_navigator.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/ntp/thumbnail_list_source.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/url_constants.h View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/common/url_constants.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lei Zhang
Created Revert of Adding the chrome://suggestions test page.
6 years, 10 months ago (2014-02-19 05:08:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/170743009/1
6 years, 10 months ago (2014-02-19 05:09:14 UTC) #2
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 05:09:45 UTC) #3
Message was sent while issue was closed.
Change committed as 251950

Powered by Google App Engine
This is Rietveld 408576698