chrome/browser/ui/webui/ntp/thumbnail_list_source.cc - Issue 170743009: Revert of Adding the chrome://suggestions test page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/ntp/thumbnail_list_source.cc

Issue 170743009: Revert of Adding the chrome://suggestions test page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/ntp/thumbnail_list_source.cc

diff --git a/chrome/browser/ui/webui/ntp/thumbnail_list_source.cc b/chrome/browser/ui/webui/ntp/thumbnail_list_source.cc

index e2683a85a807cbcf8122f47129e20a98d154b460..013244e346e791c57f74a4971b065d58a671f695 100644

--- a/chrome/browser/ui/webui/ntp/thumbnail_list_source.cc

+++ b/chrome/browser/ui/webui/ntp/thumbnail_list_source.cc

@@ -22,13 +22,13 @@

namespace {

-const char* kHtmlHeader =

- "<!DOCTYPE html>\n<html>\n<head>\n<title>TopSites Thumbnails</title>\n"

+const char* html_header =

+ "<!DOCTYPE HTML>\n<html>\n<head>\n<title>TopSites Thumbnails</title>\n"

"<meta charset=\"utf-8\">\n"

"<style type=\"text/css\">\nimg.thumb {border: 1px solid black;}\n"

"li {white-space: nowrap;}\n</style>\n";

-const char* kHtmlBody = "</head>\n<body>\n";

-const char* kHtmlFooter = "</body>\n</html>\n";

+const char* html_body = "</head>\n<body>\n";

+const char* html_footer = "</body>\n</html>\n";

// If |want_thumbnails| == true, then renders elements in |mvurl_list| that have

// thumbnails, with their thumbnails. Otherwise renders elements in |mvurl_list|

@@ -137,8 +137,8 @@

// Render HTML to embed URLs and thumbnails.

std::vector<std::string> out;

- out.push_back(kHtmlHeader);

- out.push_back(kHtmlBody);

+ out.push_back(html_header);

+ out.push_back(html_body);

if (num_mv_with_thumb > 0) {

out.push_back("<h2>TopSites URLs with Thumbnails</h2>\n");

RenderMostVisitedURLList(mvurl_list, base64_encoded_pngs, true, &out);

@@ -147,7 +147,7 @@

out.push_back("<h2>TopSites URLs without Thumbnails</h2>\n");

RenderMostVisitedURLList(mvurl_list, base64_encoded_pngs, false, &out);

}

- out.push_back(kHtmlFooter);

+ out.push_back(html_footer);

std::string out_html = JoinString(out, "");

callback.Run(base::RefCountedString::TakeString(&out_html));

« no previous file with comments | « chrome/browser/ui/browser_navigator.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »