Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 170743003: Properly initialize logging in quic_server and quic_client so (Closed)

Created:
6 years, 10 months ago by Ryan Hamilton
Modified:
6 years, 10 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, Ryan Sleevi, tfarina
Visibility:
Public.

Description

Properly initialize logging in quic_server and quic_client so that --v=1 is functional. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251903

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M net/tools/quic/quic_client_bin.cc View 1 chunk +5 lines, -0 lines 3 comments Download
M net/tools/quic/quic_server_bin.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ryan Hamilton
rtenneti: please take a look rsleevi: FYI since you care about logging in net
6 years, 10 months ago (2014-02-18 20:44:44 UTC) #1
ramant (doing other things)
lgtm
6 years, 10 months ago (2014-02-18 22:20:44 UTC) #2
Ryan Hamilton
The CQ bit was checked by rch@chromium.org
6 years, 10 months ago (2014-02-18 22:21:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/170743003/1
6 years, 10 months ago (2014-02-18 22:22:34 UTC) #4
commit-bot: I haz the power
Change committed as 251903
6 years, 10 months ago (2014-02-19 00:49:56 UTC) #5
tfarina
6 years, 10 months ago (2014-02-25 17:47:19 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/170743003/diff/1/net/tools/quic/quic_client_b...
File net/tools/quic/quic_client_bin.cc (right):

https://codereview.chromium.org/170743003/diff/1/net/tools/quic/quic_client_b...
net/tools/quic/quic_client_bin.cc:23: std::string FLAGS_address = "127.0.0.1";
while you are here, you may want to change this to:

const char FLAGS_address[] = "...";
const char FLAGS_hostname[] = "...";

https://codereview.chromium.org/170743003/diff/1/net/tools/quic/quic_client_b...
net/tools/quic/quic_client_bin.cc:26: int main(int argc, char *argv[]) {
nit (not you and not related to the patch): char* argv[] or char** argv

https://codereview.chromium.org/170743003/diff/1/net/tools/quic/quic_client_b...
net/tools/quic/quic_client_bin.cc:43: std::cout << help_str;
fprintf(stdout, help_str); might work here as well (or stderr). or just
printf(help_str);

btw, don't you want std::endl here too?

Powered by Google App Engine
This is Rietveld 408576698