Properly initialize logging in quic_server and quic_client so

net/tools/quic/quic_client_bin.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // A binary wrapper for QuicClient.  Connects to --hostname via --address
 // on --port and requests URLs specified on the command line.
 //
 // For example:
 //  quic_client --address=127.0.0.1 --port=6122 --hostname=www.google.com
 //      http://www.google.com/index.html http://www.google.com/favicon.ico
 
 #include <iostream>
 
 #include "base/at_exit.h"
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/strings/string_number_conversions.h"
 #include "net/base/ip_endpoint.h"
 #include "net/quic/quic_protocol.h"
 #include "net/tools/quic/quic_client.h"
 
 int32 FLAGS_port = 6121;
 std::string FLAGS_address = "127.0.0.1";

[tfarina, 2014/02/25 17:47:20]

while you are here, you may want to change this to:

const char FLAGS_address[] = "...";
const char FLAGS_hostname[] = "...";

 std::string FLAGS_hostname = "localhost";
 
 int main(int argc, char *argv[]) {

[tfarina, 2014/02/25 17:47:20]

nit (not you and not related to the patch): char* argv[] or char** argv

   CommandLine::Init(argc, argv);
   CommandLine* line = CommandLine::ForCurrentProcess();
+
+  logging::LoggingSettings settings;
+  settings.logging_dest = logging::LOG_TO_SYSTEM_DEBUG_LOG;
+  CHECK(logging::InitLogging(settings));
+
   if (line->HasSwitch("h") || line->HasSwitch("help")) {
     const char* help_str =
         "Usage: quic_client [options]\n"
         "\n"
         "Options:\n"
         "-h, --help                  show this help message and exit\n"
         "--port=<port>               specify the port to connect to\n"
         "--address=<address>         specify the IP address to connect to\n"
         "--host=<host>               specify the SNI hostname to use\n";
     std::cout << help_str;

[tfarina, 2014/02/25 17:47:20]

fprintf(stdout, help_str); might work here as well (or stderr). or just
printf(help_str);

btw, don't you want std::endl here too?

     exit(0);
   }
   if (line->HasSwitch("port")) {
     int port;
     if (base::StringToInt(line->GetSwitchValueASCII("port"), &port)) {
       FLAGS_port = port;
     }
   }
   if (line->HasSwitch("address")) {
     FLAGS_address = line->GetSwitchValueASCII("address");
@@ skipping 14 matching lines @@
       net::IPEndPoint(addr, FLAGS_port), FLAGS_hostname,
       net::QuicSupportedVersions(), true);
 
   client.Initialize();
 
   if (!client.Connect()) return 1;
 
   client.SendRequestsAndWaitForResponse(line->GetArgs());
   return 0;
 }