[DevTools] Support CommandLineAPI in snippets

[DevTools] Support CommandLineAPI in snippets

BUG=260401
R=dgozman@chromium.org
TBR=pfeldman@chromium.org

Committed: https://crrev.com/570287aff53d12afc29afb566bbe1e5f4ab22dc6
Cr-Commit-Position: refs/heads/master@{#376262}

[kozy, 2016-02-17 20:24:10]

Patchset #1 (id:1) has been deleted

[kozy, 2016-02-17 20:27:02]

Patchset #1 (id:20001) has been deleted

[kozy, 2016-02-17 20:27:29]

Dmitry, please take a look!

[dgozman, 2016-02-17 23:47:43]

https://codereview.chromium.org/1707043002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-model.html
(left):

https://codereview.chromium.org/1707043002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-model.html:205:
evaluateSnippetAndDumpEvaluationDetails(uiSourceCode1, context, next);
Bring this one back.

https://codereview.chromium.org/1707043002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/protocol.json (right):

https://codereview.chromium.org/1707043002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/protocol.json:1018: { "name":
"includeCommandLineAPI", "type": "boolean", "optional": true, "description":
"Determines whether Command Line API should be available during the
evaluation.", "hidden": true }
Remove hidden - the whole method is hidden.

https://codereview.chromium.org/1707043002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
(right):

https://codereview.chromium.org/1707043002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:252:
v8::Local<v8::Symbol> commandLineAPISymbolValue =
V8Debugger::commandLineAPISymbol(isolate);
Let's move this to InjectedScript to avoid exposing commandLineAPI.

[kozy, 2016-02-18 00:27:33]

All done.

https://codereview.chromium.org/1707043002/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-model.html
(left):

https://codereview.chromium.org/1707043002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/script-snippet-model.html:205:
evaluateSnippetAndDumpEvaluationDetails(uiSourceCode1, context, next);
On 2016/02/17 23:47:43, dgozman wrote:
> Bring this one back.

Done.

https://codereview.chromium.org/1707043002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/protocol.json (right):

https://codereview.chromium.org/1707043002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/protocol.json:1018: { "name":
"includeCommandLineAPI", "type": "boolean", "optional": true, "description":
"Determines whether Command Line API should be available during the
evaluation.", "hidden": true }
On 2016/02/17 23:47:43, dgozman wrote:
> Remove hidden - the whole method is hidden.

Done.

https://codereview.chromium.org/1707043002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp
(right):

https://codereview.chromium.org/1707043002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp:252:
v8::Local<v8::Symbol> commandLineAPISymbolValue =
V8Debugger::commandLineAPISymbol(isolate);
On 2016/02/17 23:47:43, dgozman wrote:
> Let's move this to InjectedScript to avoid exposing commandLineAPI.

Done.

[dgozman, 2016-02-18 01:28:33]

lgtm

https://codereview.chromium.org/1707043002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp (right):

https://codereview.chromium.org/1707043002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp:354:
global->Set(commandLineAPISymbolValue, commandLineAPI->ToObject(m_isolate));
nit: remove ->ToObject

[kozy, 2016-02-18 01:55:01]

All done.

https://codereview.chromium.org/1707043002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp (right):

https://codereview.chromium.org/1707043002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp:354:
global->Set(commandLineAPISymbolValue, commandLineAPI->ToObject(m_isolate));
On 2016/02/18 01:28:33, dgozman wrote:
> nit: remove ->ToObject

Done.

[kozy, 2016-02-18 01:55:10]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-02-18 01:55:11]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1707043002/#ps80001
(title: " ")

[commit-bot: I haz the power, 2016-02-18 01:55:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1707043002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1707043002/80001

[kozy, 2016-02-18 02:05:17]

Description was changed from

==========
[DevTools] Support CommandLineAPI in snippets

BUG=260401
R=dgozman@chromium.org
==========

to

==========
[DevTools] Support CommandLineAPI in snippets

BUG=260401
R=dgozman@chromium.org,pfeldman@chromium.org
==========

[kozy, 2016-02-18 02:05:17]

kozyatinskiy@chromium.org changed reviewers:
+ pfeldman@chromium.org

[commit-bot: I haz the power, 2016-02-18 02:05:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-18 02:05:45]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[kozy, 2016-02-18 02:05:51]

Pavel, ptal.
I need owner lgtm for platform.

[kozy, 2016-02-18 19:59:14]

Description was changed from

==========
[DevTools] Support CommandLineAPI in snippets

BUG=260401
R=dgozman@chromium.org,pfeldman@chromium.org
==========

to

==========
[DevTools] Support CommandLineAPI in snippets

BUG=260401
R=dgozman@chromium.org
TBR=pfeldman@chromium.org
==========

[kozy, 2016-02-18 19:59:31]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-02-18 20:05:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1707043002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1707043002/80001

[commit-bot: I haz the power, 2016-02-18 21:14:16]

Description was changed from

==========
[DevTools] Support CommandLineAPI in snippets

BUG=260401
R=dgozman@chromium.org
TBR=pfeldman@chromium.org
==========

to

==========
[DevTools] Support CommandLineAPI in snippets

BUG=260401
R=dgozman@chromium.org
TBR=pfeldman@chromium.org
==========

[commit-bot: I haz the power, 2016-02-18 21:14:17]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-02-18 21:15:25]

Description was changed from

==========
[DevTools] Support CommandLineAPI in snippets

BUG=260401
R=dgozman@chromium.org
TBR=pfeldman@chromium.org
==========

to

==========
[DevTools] Support CommandLineAPI in snippets

BUG=260401
R=dgozman@chromium.org
TBR=pfeldman@chromium.org

Committed: https://crrev.com/570287aff53d12afc29afb566bbe1e5f4ab22dc6
Cr-Commit-Position: refs/heads/master@{#376262}
==========

[commit-bot: I haz the power, 2016-02-18 21:15:26]

Patchset 3 (id:??) landed as
https://crrev.com/570287aff53d12afc29afb566bbe1e5f4ab22dc6
Cr-Commit-Position: refs/heads/master@{#376262}