[DevTools] Support CommandLineAPI in snippets

third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 197 matching lines @@
 
     if (!persistScript)
         return;
 
     String scriptValueId = String::number(script->GetUnboundScript()->GetId());
     OwnPtr<v8::Global<v8::Script>> global = adoptPtr(new v8::Global<v8::Script>(isolate, script));
     m_compiledScripts.set(scriptValueId, global.release());
     *scriptId = scriptValueId;
 }
 
-void V8RuntimeAgentImpl::runScript(ErrorString* errorString, const ScriptId& scriptId, int executionContextId, const String* const objectGroup, const bool* const doNotPauseOnExceptionsAndMuteConsole, RefPtr<RemoteObject>& result, RefPtr<ExceptionDetails>& exceptionDetails)
+void V8RuntimeAgentImpl::runScript(ErrorString* errorString, const ScriptId& scriptId, int executionContextId, const String* const objectGroup, const bool* const doNotPauseOnExceptionsAndMuteConsole, const bool* includeCommandLineAPI, RefPtr<RemoteObject>& result, RefPtr<ExceptionDetails>& exceptionDetails)
 {
     if (!m_enabled) {
         *errorString = "Runtime agent is not enabled";
         return;
     }
     InjectedScript* injectedScript = m_injectedScriptManager->findInjectedScript(executionContextId);
     if (!injectedScript) {
         *errorString = "Inspected frame has gone";
         return;
     }
@@ skipping 12 matching lines @@
     v8::Local<v8::Context> context = injectedScript->context();
     v8::Context::Scope scope(context);
     OwnPtr<v8::Global<v8::Script>> scriptWrapper = m_compiledScripts.take(scriptId);
     v8::Local<v8::Script> script = scriptWrapper->Get(isolate);
 
     if (script.IsEmpty()) {
         *errorString = "Script execution failed";
         return;
     }
     v8::TryCatch tryCatch(isolate);
+
+    v8::Local<v8::Symbol> commandLineAPISymbolValue = V8Debugger::commandLineAPISymbol(isolate);

[dgozman, 2016/02/17 23:47:43]

Let's move this to InjectedScript to avoid exposing commandLineAPI.

[kozy, 2016/02/18 00:27:33]

Done.

+    v8::Local<v8::Object> global = context->Global();
+    if (asBool(includeCommandLineAPI)) {
+        v8::Local<v8::Value> commandLineAPI = injectedScript->commandLineAPI();
+        if (commandLineAPI->IsObject())
+            global->Set(commandLineAPISymbolValue, commandLineAPI->ToObject(isolate));
+    }
+
     v8::Local<v8::Value> value;
     v8::MaybeLocal<v8::Value> maybeValue = m_debugger->client()->runCompiledScript(context, script);
     if (maybeValue.IsEmpty()) {
         value = tryCatch.Exception();
         v8::Local<v8::Message> message = tryCatch.Message();
         if (!message.IsEmpty())
             exceptionDetails = createExceptionDetails(isolate, message);
     } else {
         value = maybeValue.ToLocalChecked();
     }
 
+    if (asBool(includeCommandLineAPI))
+        global->Delete(context, commandLineAPISymbolValue);
+
     if (value.IsEmpty()) {
         *errorString = "Script execution failed";
         return;
     }
 
     result = injectedScript->wrapObject(value, objectGroup ? *objectGroup : "");
 }
 
 void V8RuntimeAgentImpl::setInspectorState(PassRefPtr<JSONObject> state)
 {
@@ skipping 129 matching lines @@
     RefPtr<ExceptionDetails> exceptionDetails = ExceptionDetails::create().setText(toWTFStringWithTypeCheck(message->Get()));
     exceptionDetails->setLine(message->GetLineNumber());
     exceptionDetails->setColumn(message->GetStartColumn());
     v8::Local<v8::StackTrace> messageStackTrace = message->GetStackTrace();
     if (!messageStackTrace.IsEmpty() && messageStackTrace->GetFrameCount() > 0)
         exceptionDetails->setStack(m_debugger->createStackTrace(messageStackTrace, messageStackTrace->GetFrameCount())->buildInspectorObject());
     return exceptionDetails.release();
 }
 
 } // namespace blink