Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1706623002: Add the latest support library changes to the client example (Closed)

Created:
4 years, 10 months ago by Yusuf
Modified:
4 years, 10 months ago
Reviewers:
Ian Wen
Base URL:
https://chromium.googlesource.com/external/github.com/GoogleChrome/custom-tabs-client.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add the latest support library changes to the client example - Address API review comments - Renamed calls to have toolbar instead of action bar. Added more explanation for max number of items. Fixed javadocs. BUG=587170 Committed: https://github.com/GoogleChrome/custom-tabs-client/commit/8ae46d26e739899d2e35f462beeb20e9c194d0ab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -33 lines) Patch
M customtabs/src/android/support/customtabs/CustomTabsIntent.java View 7 chunks +29 lines, -26 lines 0 comments Download
M customtabs/src/android/support/customtabs/CustomTabsSession.java View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Yusuf
4 years, 10 months ago (2016-02-17 00:45:29 UTC) #2
Ian Wen
lgtm
4 years, 10 months ago (2016-02-17 02:00:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1706623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1706623002/1
4 years, 10 months ago (2016-02-17 04:25:21 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 04:26:44 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://github.com/GoogleChrome/custom-tabs-client/commit/8ae46d26e739899d2e3...

Powered by Google App Engine
This is Rietveld 408576698