Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: customtabs/src/android/support/customtabs/CustomTabsSession.java

Issue 1706623002: Add the latest support library changes to the client example (Closed) Base URL: https://chromium.googlesource.com/external/github.com/GoogleChrome/custom-tabs-client.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « customtabs/src/android/support/customtabs/CustomTabsIntent.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: customtabs/src/android/support/customtabs/CustomTabsSession.java
diff --git a/customtabs/src/android/support/customtabs/CustomTabsSession.java b/customtabs/src/android/support/customtabs/CustomTabsSession.java
index 43359765ba05050329869667d724ec0952f38b06..db6c2b7b0db5c56a2c3a6d18e97d1a270f1f2e02 100644
--- a/customtabs/src/android/support/customtabs/CustomTabsSession.java
+++ b/customtabs/src/android/support/customtabs/CustomTabsSession.java
@@ -74,21 +74,21 @@ public final class CustomTabsSession {
* @param icon The new icon of the action button.
* @param description Content description of the action button.
*
- * @see {@link CustomTabsSession#setActionBarItem(int, Bitmap, String)}
+ * @see {@link CustomTabsSession#setToolbarItem(int, Bitmap, String)}
*/
public boolean setActionButton(@NonNull Bitmap icon, @NonNull String description) {
- return setActionBarItem(CustomTabsIntent.TOOLBAR_ACTION_BUTTON_ID, icon, description);
+ return setToolbarItem(CustomTabsIntent.TOOLBAR_ACTION_BUTTON_ID, icon, description);
}
/**
- * Updates the visuals for action bar items. Will only succeed if the given
- * session is the active one in browser and the given id is valid.
+ * Updates the visuals for toolbar items. Will only succeed if a custom tab created using this
+ * session is in the foreground in browser and the given id is valid.
* @param id The id for the item to update.
- * @param icon The new icon of the action bar item.
- * @param description Content description of the action bar item.
+ * @param icon The new icon of the toolbar item.
+ * @param description Content description of the toolbar item.
* @return Whether the update succeeded.
*/
- public boolean setActionBarItem(int id, @NonNull Bitmap icon, @NonNull String description) {
+ public boolean setToolbarItem(int id, @NonNull Bitmap icon, @NonNull String description) {
Bundle bundle = new Bundle();
bundle.putInt(CustomTabsIntent.KEY_ID, id);
bundle.putParcelable(CustomTabsIntent.KEY_ICON, icon);
« no previous file with comments | « customtabs/src/android/support/customtabs/CustomTabsIntent.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698